Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Providing unit test to snippet GH32414 #43136

Closed
wants to merge 1 commit into from
Closed

TST Providing unit test to snippet GH32414 #43136

wants to merge 1 commit into from

Conversation

Bhavay-2001
Copy link

@Bhavay-2001 Bhavay-2001 commented Aug 20, 2021

A unit test has been added to check the validity of pd.Categorical() . This PR is with respect to the GitHub issue no. 32414.
Thanks

@pep8speaks
Copy link

Hello @Bhavay192! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 4:1: E302 expected 2 blank lines, found 1
Line 5:3: E111 indentation is not a multiple of four
Line 6:7: E111 indentation is not a multiple of four
Line 6:89: E501 line too long (108 > 88 characters)
Line 7:3: E111 indentation is not a multiple of four
Line 9:3: E111 indentation is not a multiple of four
Line 10:3: E111 indentation is not a multiple of four
Line 11:3: E111 indentation is not a multiple of four
Line 13:1: E302 expected 2 blank lines, found 1
Line 14:1: W293 blank line contains whitespace
Line 15:3: E111 indentation is not a multiple of four
Line 16:89: E501 line too long (94 > 88 characters)
Line 17:89: E501 line too long (104 > 88 characters)
Line 19:3: E111 indentation is not a multiple of four
Line 22:1: E305 expected 2 blank lines after class or function definition, found 1
Line 22:24: E231 missing whitespace after ','
Line 22:49: W292 no newline at end of file

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should be placed in pandas/tests/series/methods/test_fillna.py and should mimic the tests in that file.

@jreback jreback added Categorical Categorical Data Type ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite labels Aug 21, 2021
@Bhavay-2001
Copy link
Author

hey @mroeschke , thanks for taking the time to preview my pull request and responding. As per your comment, should I just add my code under the given file, or do I need to add any further checks ??

@mroeschke
Copy link
Member

You would just need to put this test in that file I mentioned and format the test like the others in that file

@Bhavay-2001
Copy link
Author

hey @mroeschke , thanks for replying. I just added the that test to the file you mentioned. As my PR gets reviewed, my tests seems to be broken as it is not passing the ci test and also has an liniting error. Could you help me with that please. Thanks

@mroeschke
Copy link
Member

Please review the entirety of this page for how to make a pull request: https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html

@Bhavay-2001
Copy link
Author

hey @mroeschke, I have made a pull request and have added my test into the folder you specified. But I mistakenly made a new pull request and there are some warnings in that. I request you to please help me in that PR. PR no. is 43230

@mroeschke
Copy link
Member

Okay will close this in favor of that PR: #43230

@mroeschke mroeschke closed this Aug 27, 2021
@Bhavay-2001
Copy link
Author

Yaa thanks and please help me with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EA: fillna should accept same type
4 participants