-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST Providing unit test to snippet GH32414 #43136
Conversation
Hello @Bhavay192! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be placed in pandas/tests/series/methods/test_fillna.py
and should mimic the tests in that file.
hey @mroeschke , thanks for taking the time to preview my pull request and responding. As per your comment, should I just add my code under the given file, or do I need to add any further checks ?? |
You would just need to put this test in that file I mentioned and format the test like the others in that file |
hey @mroeschke , thanks for replying. I just added the that test to the file you mentioned. As my PR gets reviewed, my tests seems to be broken as it is not passing the ci test and also has an liniting error. Could you help me with that please. Thanks |
Please review the entirety of this page for how to make a pull request: https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html |
hey @mroeschke, I have made a pull request and have added my test into the folder you specified. But I mistakenly made a new pull request and there are some warnings in that. I request you to please help me in that PR. PR no. is 43230 |
Okay will close this in favor of that PR: #43230 |
Yaa thanks and please help me with that |
A unit test has been added to check the validity of pd.Categorical() . This PR is with respect to the GitHub issue no. 32414.
Thanks