Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_fillna.py #46161

Merged
merged 3 commits into from
Feb 27, 2022
Merged

Update test_fillna.py #46161

merged 3 commits into from
Feb 27, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Feb 26, 2022 •
edited
Loading

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Feb 26, 2022
mroeschke
mroeschke approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@mroeschke mroeschke added this to the 1.5 milestone Feb 27, 2022
@mroeschke mroeschke merged commit de98025 into pandas-dev:main Feb 27, 2022
@mroeschke
Copy link
Member

Thanks again @weikhor!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@yehoshuadimarsky
Update test_fillna.py (pandas-dev#46161)
13b430f 
* Update test_fillna.py

* change test function name

* change assert categorical equal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

EA: fillna should accept same type
2 participants
@weikhor @mroeschke