Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: split up test_concat.py #37243

Closed
jreback opened this issue Oct 19, 2020 · 2 comments · Fixed by #37387
Closed

TST: split up test_concat.py #37243

jreback opened this issue Oct 19, 2020 · 2 comments · Fixed by #37387
Assignees
@kamilt5
Labels
good first issue Testing pandas testing functions or related to the test suite
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented Oct 19, 2020

we should split this to a sub-module (concat) and then split logically (similar to merge)

https://github.com/pandas-dev/pandas/blob/master/pandas/tests/reshape/test_concat.py
@jreback jreback added Testing pandas testing functions or related to the test suite good first issue labels Oct 19, 2020
@jreback jreback added this to the Contributions Welcome milestone Oct 19, 2020
@kamilt5
Copy link
Contributor

kamilt5 commented Oct 19, 2020

Hello,
i want contribute to this issue. I am not completely sure about files content, so let me know if I need to change something. I will make PR in about 30 minutes.

@kamilt5
Copy link
Contributor

kamilt5 commented Oct 19, 2020

take

kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 19, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
e03efd1
@jreback jreback mentioned this issue Oct 20, 2020
Closed
5 tasks
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 20, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
75d49cf
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 20, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
f259227
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 23, 2020
@kamilt5
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243)
4cfa5a0
jreback pushed a commit that referenced this issue Oct 23, 2020
@kamilt5
TST: moved file test_concat.py to folder ./concat/ (#37243) (#37360)
b49aeac
arw2019 pushed a commit to arw2019/pandas that referenced this issue Oct 23, 2020
@kamilt5 @arw2019
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
eba6c41 
…pandas-dev#37360)
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 23, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243 - follows up
b6b0692 
* created test_datetime.py and
  split datetime/timezone/period related tests
jreback pushed a commit that referenced this issue Oct 23, 2020
@kamilt5
TST: split up test_concat.py #37243 - follows up (#37368)
9fd30b7
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 24, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
3903d6f 
 * created test_categorical.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 24, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
990575d 
 * created test_empty.py

 * changes to test_series.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 25, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
a06c50f 
 * created test_categorical.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 25, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
1d2e424 
 * created test_empty.py

 * changes to test_series.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 25, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
84d0415 
 * created test_invalid.py

 * created test_sort.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 25, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
ca9a84c 
 * created test_index.py

 * small changes to test_empty.py, test_datetimes.py, test_dataframe.py
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Oct 26, 2020
@kamilt5 @JulianWgs
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
4e8b57e 
…pandas-dev#37360)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Oct 26, 2020
@kamilt5 @JulianWgs
TST: split up test_concat.py pandas-dev#37243 - follows up (pandas-de…
9caab8e 
…v#37368)
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 26, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
ad7a7c6 
 * created conftest.py
@kamilt5 kamilt5 mentioned this issue Oct 26, 2020
Merged
5 tasks
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 26, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
faa0e0b 
 * reverted changes to test_series.py
kamilt5 added a commit to kamilt5/pandas that referenced this issue Oct 26, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243
665d932 
 * small changes in test_datetimes.py
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Oct 28, 2020
jreback pushed a commit that referenced this issue Oct 28, 2020
@kamilt5
TST: split up test_concat.py #37243 - more follows up (#37387)
e149880
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@kamilt5
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
cd532fb 
…pandas-dev#37360)
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243 - follows up (pandas-de…
ffcc738 
…v#37368)
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@kamilt5
TST: split up test_concat.py pandas-dev#37243 - more follows up (pand…
5318053 
…as-dev#37387)
ukarroum pushed a commit to ukarroum/pandas that referenced this issue Nov 2, 2020
@kamilt5 @ukarroum
TST: split up test_concat.py pandas-dev#37243 - more follows up (pand…
e2440ca 
…as-dev#37387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilt5 kamilt5

Labels
good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
2 participants
@jreback @kamilt5