Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: moved file test_concat.py to folder ./concat/ (#37243) #37360

Merged
merged 7 commits into from
Oct 23, 2020
Merged

TST: moved file test_concat.py to folder ./concat/ (#37243) #37360

merged 7 commits into from
Oct 23, 2020

Conversation

kamilt5
Copy link
Contributor

@kamilt5 kamilt5 commented Oct 23, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

kamilt5
kamilt5 commented Oct 23, 2020
View reviewed changes
pandas/tests/reshape/concat/test_concat.py Outdated
@@ -1845,124 +1845,6 @@ def test_concat_preserves_extension_int64_dtype():
tm.assert_frame_equal(result, expected)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is typo in commit message, it should be "split class TestSeriesConcat to file test_series.py"

@kamilt5 kamilt5 mentioned this pull request Oct 23, 2020
Closed
5 tasks
@kamilt5
Copy link
Contributor Author

kamilt5 commented Oct 23, 2020

so after merging this PR to master, I will be able to create new PR and do follows-up? Further splitting to "test_categorial", "test_empty" require moving methods, so doing this will be better in another PR, yes?

@jreback jreback added this to the 1.2 milestone Oct 23, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 23, 2020
@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

ok, need you to run the pre-commit hooks: https://github.com/pandas-dev/pandas/pull/37360/checks?check_run_id=1297616903

and ping on green and can merge (then can do followups).

@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

great ping on green.

@kamilt5
Copy link
Contributor Author

kamilt5 commented Oct 23, 2020

Ugh, why did it crash with:
AssertionError: ('pandas/tests/io/parser/test_c_parser_only.py::test_parse_trim_buffers[c_low]', )

Is it connected with my commit?

@jreback jreback merged commit b49aeac into pandas-dev:master Oct 23, 2020
@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

thanks @laffite56

no the windows checks have been finicky lately.

pls issue followon PRs to clean this up.

arw2019 pushed a commit to arw2019/pandas that referenced this pull request Oct 23, 2020
@kamilt5 @arw2019
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
eba6c41 
…pandas-dev#37360)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@kamilt5 @JulianWgs
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
4e8b57e 
…pandas-dev#37360)
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@kamilt5
TST: moved file test_concat.py to folder ./concat/ (pandas-dev#37243) (…
cd532fb 
…pandas-dev#37360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilt5 @jreback