-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Remove MultiIndex._get_grouper_for_level #49452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
can get more description? |
take |
@Himanshuwagh - I'd be happy to - is there a part that is unclear? @natmokval - It looks like @TaylorChaseHunter is already preparing a PR for this issue. |
Oh I'm sorry, I was just kind of practicing the process -- I didn't realize it notified here. @natmokval please feel free to take it and I'll remove my commit. |
Ah - no problem @TaylorChaseHunter. Thanks for letting us know! |
Oops, my mistake. I am quite new to the process too. @TaylorChaseHunter please take the issue and don’t remove your commit. |
take |
@rhshadrach I made changes off the main branch but tests failed. Pretty sure your changes in #49373 are necessary? If so, should I branch off your branch or wait for that to merge then cleanup? Thanks! edit: clearly depends on #49373. I'll wait for that merge then PR |
Exactly right @codamuse - that PR should be merged in the next few days, thanks for waiting. |
Hi! I am a first time contributor and would love to help. Is there anything that I could possibly be assigned to or help out with? |
@rhshadrach Sorry but I've been trying to get tests to pass locally and not having much success. I cloned a fresh repo from |
encouragingly the CI tests all passed...I'll try to sort out my local environment but I think this PR should be okay |
#49373 removed its only use. Since it's implemented on
Index
as well (where it's still needed), I think we should raise NotImplementedError to prevent any hard-to-understand tracebacks.The text was updated successfully, but these errors were encountered: