BUG: groupby with CategoricalIndex doesn't include unobserved categories #49373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
commented
Oct 28, 2022
No problem! I think this should pretty much cover the changes in #49318 so will close my PR. |
4 tasks
mroeschke
reviewed
Oct 31, 2022
mroeschke
reviewed
Oct 31, 2022
jbrockmendel
reviewed
Nov 1, 2022
| @@ -542,6 +537,14 @@ def __init__( | |||
| # TODO 2022-10-08 we only have one test that gets here and | |||
| # values are already in nanoseconds in that case. | |||
| self.grouping_vector = Series(self.grouping_vector).to_numpy() | |||
| elif is_categorical_dtype(self.grouping_vector): | |||
There was a problem hiding this comment.
any particular reason this was moved from above?
There was a problem hiding this comment.
Previously, this block was in an if...elif...elif... chain where it would be skipped over when the first if was true (namely, when the grouping is specified by a level in the index). Now it's moved out of that chain, so it's always hit when appropriate.
mroeschke
reviewed
Nov 2, 2022
| @@ -1235,10 +1289,10 @@ def df_cat(df): | |||
| @pytest.mark.parametrize("operation", ["agg", "apply"]) | |||
| def test_seriesgroupby_observed_true(df_cat, operation): | |||
| # GH 24880 | |||
There was a problem hiding this comment.
Nit: Could you add the GH reference related to why this test changed?
mroeschke
reviewed
Nov 2, 2022
…pby_cat_unobserved
…h/pandas into groupby_cat_unobserved
mroeschke
approved these changes
Nov 7, 2022
|
Thanks @rhshadrach |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
…ies (pandas-dev#49373) * BUG: groupby with CategoricalIndex doesn't include unobserved categories * Test fixup * cleanup * Remove TODO * Add GH reference * Add GH reference
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…ies (pandas-dev#49373) * BUG: groupby with CategoricalIndex doesn't include unobserved categories * Test fixup * cleanup * Remove TODO * Add GH reference * Add GH reference
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.@gt-on-1234 - my apologies here; I was meaning to just tackle #49354 but found that my changes leaked over into #49223. Take a look and let me know what you think.