Skip to content

BUG: GH10355 groupby std() no longer sqrts grouping cols #11300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

henrystokeley
Copy link

closes #10355

Previously grouping columns were square rooted when as_index=False
New method closely follows the format of var() method.

Previously grouping columns were square rooted when as_index=False
New method closely follows the format of var() method.
@jreback
Copy link
Contributor

jreback commented Oct 12, 2015

see comments on #11085 w.r.t. performance of this

@henrystokeley
Copy link
Author

My solution is slightly different from #11085 (I keep the distinction from ddof == 1 and ddof != 1)
I believe my solution is essentially the same as the sketch one proposed on #10355 where you calculate the solution and then take the square root.

Isn't this the same performance-wise as the current method which just square roots the answer from var() (but also includes unnecessary columns)
I'm not an expert on performance so could you clarify this for me?

@jreback
Copy link
Contributor

jreback commented Oct 12, 2015

the problem is that when you go to a python soln it is evaluated for every group rather than using the cython function. The soln needs to simply take the .var (with the correct ddof), then np.sqrt on the result (excluding the selection columns).

@jreback
Copy link
Contributor

jreback commented Oct 15, 2015

can you update according to comments

@jreback
Copy link
Contributor

jreback commented Oct 25, 2015

@henrystokeley can you update according to comments

@jreback
Copy link
Contributor

jreback commented Nov 5, 2015

replaced by #11507

@xieyuheng
Copy link

#25315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: STD modifies groupby target column when as_index=False
3 participants