DEPR: Deprecated Index.to_datetime #14096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
to-datetime-depr
branch
from
9adbe1f to
efa9885
Compare
Current coverage is 85.27% (diff: 100%)@@ master #14096 diff @@
==========================================
Files 139 139
Lines 50489 50490 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43052 43053 +1
Misses 7437 7437
Partials 0 0
|
|
@jorisvandenbossche : Since Travis is passing, and if there are no complaints, IMO this can be merged? |
Partially addresses pandas-devgh-8254. Closes pandas-devgh-8612 because pd.to_datetime has a format arg. [ci skip]
gfyoung
force-pushed
the
to-datetime-depr
branch
from
efa9885 to
5512837
Compare
|
I would add the deprecation of Timestamp.to_datetime as well, if you are ok with that? |
|
The reasons for deprecation are slightly different though. When I looked into it, the deprecation was a little more complicated. This change, however, was relatively trivial. 😄 I would feel more comfortable doing it in a separate PR if that's okay. |
|
OK, that's fine :-) Thanks! |
|
@jorisvandenbossche : Also, add that deprecation to #6581. |
1 task
|
@gfyoung yep, thanks, added |
5 tasks
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 5, 2017
Removes the following .to_datetime methods * Index.to_datetime * Timestamp.to_datetime * PeriodIndex.to_datetime * DatetimeIndex.to_datetime All were deprecated in 0.19.0 xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 6, 2017
Removes the following .to_datetime methods * Index.to_datetime * NaTType.to_datetime * Timestamp.to_datetime * PeriodIndex.to_datetime * DatetimeIndex.to_datetime All were deprecated in 0.19.0 xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113
gfyoung
added a commit
that referenced
this pull request
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates both
Index.to_datetimeandDatetimeIndex.to_datetimein favor ofpd.to_datetime.Partially addresses #8254.
Closes #5612 because
pd.to_datetimedoes have aformatargument.