CLN: Remove .to_datetime methods #18648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I forgot some |
jorisvandenbossche
approved these changes
Dec 5, 2017
jreback
approved these changes
Dec 6, 2017
| @@ -888,12 +870,6 @@ def test_to_datetime_list_of_integers(self): | |||
|
|
|||
| tm.assert_index_equal(rng, result) | |||
|
|
|||
| def test_to_datetime_freq(self): | |||
| xp = bdate_range('2000-1-1', periods=10, tz='UTC') | |||
| rs = xp.to_datetime() | |||
There was a problem hiding this comment.
odd that this didn't warn before
Removes the following .to_datetime methods * Index.to_datetime * NaTType.to_datetime * Timestamp.to_datetime * PeriodIndex.to_datetime * DatetimeIndex.to_datetime All were deprecated in 0.19.0 xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113
gfyoung
force-pushed
the
to-datetime-drop
branch
from
7ce6765 to
c4977d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #18648 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.02%
==========================================
Files 153 153
Lines 51221 51236 +15
==========================================
+ Hits 46917 46924 +7
- Misses 4304 4312 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18648 +/- ##
==========================================
- Coverage 91.59% 91.55% -0.05%
==========================================
Files 153 153
Lines 51221 51205 -16
==========================================
- Hits 46917 46880 -37
- Misses 4304 4325 +21
Continue to review full report at Codecov.
|
|
All is green, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following .to_datetime methods
Index.to_datetimeTimestamp.to_datetimePeriodIndex.to_datetimeDatetimeIndex.to_datetimeAll were deprecated in 0.19.0
xref #8254, #14096, #14113