Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Isort on tests/series single pr #23344

Merged
merged 8 commits into from
Oct 28, 2018
Merged

Run Isort on tests/series single pr #23344

merged 8 commits into from
Oct 28, 2018

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Oct 25, 2018 •
edited by jreback
Loading

@pep8speaks
Copy link

Hello @thoo! Thanks for updating the PR.

jreback
jreback requested changes Oct 26, 2018
View reviewed changes
pandas/tests/series/test_api.py Outdated
@@ -698,7 +697,7 @@ def test_dt_accessor_api_for_categorical(self):

test_data = [
("Datetime", get_ops(DatetimeIndex), s_dr, c_dr),
("Period", get_ops(PeriodIndex), s_pr, c_pr),
("Period", get_ops(PeriodArray), s_pr, c_pr),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? did u mean to change

pandas/tests/series/test_constructors.py Outdated
@@ -856,17 +855,33 @@ def test_construction_consistency(self):
result = Series(s.values, dtype=s.dtype)
tm.assert_series_equal(result, s)

def test_constructor_infer_period(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were added?

pandas/tests/series/test_validate.py
@@ -1,4 +1,5 @@
import pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to update setup.cfg

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@thoo thoo force-pushed the fix_import_format_series_pr1 branch from 59ad294 to 2886d05 Compare October 26, 2018 02:39
thoo added 6 commits October 25, 2018 22:59
@thoo
update setup.cfg
2f1d4a0
@thoo
Merge remote-tracking branch 'repo_org/master' into fix_import_format…
9622556 
…_series_pr1

* repo_org/master:
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
@thoo
drop test_duplicates.py to check code_checks.sh
897b5e4
@thoo
reset test_duplicates.py to check travis ci error
f895bde
@thoo
Merge remote-tracking branch 'repo_org/master' into fix_import_format…
7390086 
…_series_pr1

* repo_org/master:
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
@thoo
add blank line
412a813
@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #23344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23344   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51261    51261           
=======================================
  Hits        47277    47277           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <ø> (ø) ⬆️
#single 42.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f662c5f...412a813. Read the comment docs.

@thoo
Copy link
Contributor Author

thoo commented Oct 28, 2018

@jreback For this one, I have to drop test_duplicates.py because there might be a bug in code_checks.sh. It thought test_duplicates.py wasn't properly isort. Other than that, it is green.

@jreback jreback merged commit c238620 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks @thoo

@thoo thoo mentioned this pull request Nov 4, 2018
Closed
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@thoo @tm9k1
Run Isort on tests/series single pr (pandas-dev#23344)
a1e9fcc
@thoo thoo deleted the fix_import_format_series_pr1 branch January 2, 2019 20:26
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Run Isort on tests/series single pr (pandas-dev#23344)
4593a2c
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Run Isort on tests/series single pr (pandas-dev#23344)
5cc54e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thoo @pep8speaks @jreback