REF: remove single-tuple special case for Categorical.__hash__ #33678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @TomAugspurger looks like this was added in #16015, LMK if this special case is actually still needed |
| cat_array = hash_array(np.asarray(categories), categorize=False) | ||
|
|
||
| if categories.dtype == "O": | ||
| if len({type(x) for x in categories}) != 1: |
There was a problem hiding this comment.
I think we'd like to avoid calling type on every element of categories. I'm guessing that will be prohibitively slow for large categories.
There was a problem hiding this comment.
Good point. Can you comment on why something like hash(str(np.asarray(categories))) wasnt used?
The imports from core.util.hashing are a hassle dependency-structure-wise, so if there is a simplification available itd be helpful, but not urgent.
There was a problem hiding this comment.
I'm not sure offhand.
|
Closing pending discussion. |
jbrockmendel
added
the
Mothballed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.