-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: remove single-tuple special case for Categorical.__hash__ #33678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c84b7e9
CLN: remove tuple kludge in CategoricalDtype.__hash__
jbrockmendel 6ed5ded
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 6aa3e2c
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel c65d85e
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 96ee4a1
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 08ea62e
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel e6be1df
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 8cb04cc
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd like to avoid calling
type
on every element of categories. I'm guessing that will be prohibitively slow for largecategories
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Can you comment on why something like
hash(str(np.asarray(categories)))
wasnt used?The imports from core.util.hashing are a hassle dependency-structure-wise, so if there is a simplification available itd be helpful, but not urgent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure offhand.