Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: bump numpy min version to 1.15.4 #33729

Merged
merged 14 commits into from
May 1, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added the Dependencies Required and optional dependencies label Apr 22, 2020
@jreback jreback added this to the 1.1 milestone Apr 22, 2020
@jbrockmendel
Copy link
Member Author

Mothballing to clear the queue

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Apr 23, 2020
@jbrockmendel jbrockmendel reopened this Apr 30, 2020
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Apr 30, 2020
| python-dateutil | 2.7.3 | X | |
| numpy | 1.15.4 | X | X |
+-----------------+-----------------+----------+---------+
| pytz | 2015.4 | X | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prob bump this just for consistency

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. what to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess 2019 ish, but maybe doesn't matter

@jbrockmendel
Copy link
Member Author

@WillAyd the MacOSPy36 failure is at build-time, any thoughts?

@TomAugspurger the LinuxPY36 failure looks like its a conda-dependency issue, any thoughts?

One of the other two failures should be fixed by #33898 leaving one more that i need to troubleshoot.

@TomAugspurger
Copy link
Contributor

Seems to be an issue between NumPy 1.15.4 and python=3.6.1

 ~  conda create -n ttttt -c defaults -c conda-forge numpy=1.15.4 python=3.6.1                                                                                                                                                                                                                                                           10.9s  Thu Apr 30 16:20:32 2020
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: |
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package python conflicts for:
python=3.6.1
numpy=1.15.4 -> python[version='>=2.7,<2.8.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']
numpy=1.15.4 -> mkl_fft[version='>=1.0.6,<2.0a0'] -> python[version='2.7.*|3.5.*|3.6.*|>=3.5,<3.6.0a0|>=3.8,<3.9.0a0']
Note that strict channel priority may have removed packages required for satisfiability.

Python 3.6.2 seems fine. I'd recommend removing the defaults channel from that build.

@WillAyd
Copy link
Member

WillAyd commented Apr 30, 2020

Haven't debugged macOS failure but one thing worth updating first perhaps is the dependency file for it. I think it still has numpy 1.14 pinned

@jbrockmendel
Copy link
Member Author

Python 3.6.2 seems fine. I'd recommend removing the defaults channel from that build.

first couple tries didnt work, any other suggestions? no rush

@TomAugspurger
Copy link
Contributor

If you're able to reproduce locally, then binary search on the env file is often best (comment out half the file, conda env create -f ..., see if it breaks).

Turns out scipy=0.19.0 was the (or at least a) problem. It's not compatible with NumPy 1.15.4.

I'd recommend bumping scipy to 1.2.0, which is the first release after NumPy 1.15.4.

@TomAugspurger
Copy link
Contributor

Can you bump the versions in pandas/compat/_optional.py for scipy and any other optional deps that are increased?

@jbrockmendel
Copy link
Member Author

I'd recommend bumping scipy to 1.2.0, which is the first release after NumPy 1.15.4.

that did the trick, thanks

@jreback jreback merged commit 81093ba into pandas-dev:master May 1, 2020
@jreback
Copy link
Contributor

jreback commented May 1, 2020

great!

@jbrockmendel jbrockmendel deleted the npbump branch May 1, 2020 20:15
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
"numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'",
"numpy==1.14.5; python_version>='3.7' and platform_system!='AIX'",
"numpy==1.15.4; python_version=='3.6' and platform_system!='AIX'",
"numpy==1.15.4; python_version>='3.7' and platform_system!='AIX'",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be "numpy>=1.15.4"? I had issues installing pandas from source with numpy 1.18.5 installed.
Should I create a ticket for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so. We build with the oldest supported NumPy that is compatible with the version of NumPy.

I had issues installing pandas from source with numpy 1.18.5 installed.

This also doesn't quite make sense. The idea behind pyproject.toml is to isolate the build environment. It shouldn't matter what version of NumPy was used to build pandas with, as long as it's binary compatible (IIUC).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, ignore my comment if that is how you make sure that your build with the oldest supported version.

In my case I have numpy 1.18.5 installed and I want to use it to build pandas from source. However, it complains that the build requirements are note met.

Installing build dependencies ... error
ERROR: Complete output from command /opt/project/venv37/bin/python3.7 /opt/project/venv37/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-0xz070yu/overlay --no-warn-script-location --no-binary :none: --only-binary :none: --no-index --find-links https://project:omniscale@pkgs.omniscale.net:443/project -- setuptools wheel 'Cython>=0.29.13' 'numpy==1.13.3; python_version=='"'"'3.6'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.14.5; python_version>='"'"'3.7'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.16.0; python_version=='"'"'3.6'"'"' and platform_system=='"'"'AIX'"'"'' 'numpy==1.16.0; python_version>='"'"'3.7'"'"' and platform_system=='"'"'AIX'"'"'':
ERROR: Ignoring numpy: markers 'python_version == "3.6" and platform_system != "AIX"' don't match your environment
Ignoring numpy: markers 'python_version == "3.6" and platform_system == "AIX"' don't match your environment
Ignoring numpy: markers 'python_version >= "3.7" and platform_system == "AIX"' don't match your environment
Looking in links: https://*redacted*
Collecting setuptools
Collecting wheel
Collecting Cython>=0.29.13
Collecting numpy==1.14.5
  ERROR: Could not find a version that satisfies the requirement numpy==1.14.5 (from versions: 1.18.5)
ERROR: No matching distribution found for numpy==1.14.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, were you using python 3.8? There was an issue with us not having a line for py38. #34667

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 3.7.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I didn't quite understood how build isolation works. Thanks for your quick relies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEP: bump numpy min version?
5 participants