-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: bump numpy min version to 1.15.4 #33729
Conversation
Mothballing to clear the queue |
| python-dateutil | 2.7.3 | X | | | ||
| numpy | 1.15.4 | X | X | | ||
+-----------------+-----------------+----------+---------+ | ||
| pytz | 2015.4 | X | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should prob bump this just for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. what to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess 2019 ish, but maybe doesn't matter
@WillAyd the MacOSPy36 failure is at build-time, any thoughts? @TomAugspurger the LinuxPY36 failure looks like its a conda-dependency issue, any thoughts? One of the other two failures should be fixed by #33898 leaving one more that i need to troubleshoot. |
Seems to be an issue between NumPy 1.15.4 and python=3.6.1
Python 3.6.2 seems fine. I'd recommend removing the |
Haven't debugged macOS failure but one thing worth updating first perhaps is the dependency file for it. I think it still has numpy 1.14 pinned pandas/ci/deps/azure-macos-36.yaml Line 22 in 1940fce
|
first couple tries didnt work, any other suggestions? no rush |
If you're able to reproduce locally, then binary search on the env file is often best (comment out half the file, Turns out scipy=0.19.0 was the (or at least a) problem. It's not compatible with NumPy 1.15.4. I'd recommend bumping scipy to 1.2.0, which is the first release after NumPy 1.15.4. |
Can you bump the versions in |
that did the trick, thanks |
great! |
"numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'", | ||
"numpy==1.14.5; python_version>='3.7' and platform_system!='AIX'", | ||
"numpy==1.15.4; python_version=='3.6' and platform_system!='AIX'", | ||
"numpy==1.15.4; python_version>='3.7' and platform_system!='AIX'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be "numpy>=1.15.4"? I had issues installing pandas from source with numpy 1.18.5 installed.
Should I create a ticket for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. We build with the oldest supported NumPy that is compatible with the version of NumPy.
I had issues installing pandas from source with numpy 1.18.5 installed.
This also doesn't quite make sense. The idea behind pyproject.toml is to isolate the build environment. It shouldn't matter what version of NumPy was used to build pandas with, as long as it's binary compatible (IIUC).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, ignore my comment if that is how you make sure that your build with the oldest supported version.
In my case I have numpy 1.18.5 installed and I want to use it to build pandas from source. However, it complains that the build requirements are note met.
Installing build dependencies ... error
ERROR: Complete output from command /opt/project/venv37/bin/python3.7 /opt/project/venv37/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-0xz070yu/overlay --no-warn-script-location --no-binary :none: --only-binary :none: --no-index --find-links https://project:omniscale@pkgs.omniscale.net:443/project -- setuptools wheel 'Cython>=0.29.13' 'numpy==1.13.3; python_version=='"'"'3.6'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.14.5; python_version>='"'"'3.7'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.16.0; python_version=='"'"'3.6'"'"' and platform_system=='"'"'AIX'"'"'' 'numpy==1.16.0; python_version>='"'"'3.7'"'"' and platform_system=='"'"'AIX'"'"'':
ERROR: Ignoring numpy: markers 'python_version == "3.6" and platform_system != "AIX"' don't match your environment
Ignoring numpy: markers 'python_version == "3.6" and platform_system == "AIX"' don't match your environment
Ignoring numpy: markers 'python_version >= "3.7" and platform_system == "AIX"' don't match your environment
Looking in links: https://*redacted*
Collecting setuptools
Collecting wheel
Collecting Cython>=0.29.13
Collecting numpy==1.14.5
ERROR: Could not find a version that satisfies the requirement numpy==1.14.5 (from versions: 1.18.5)
ERROR: No matching distribution found for numpy==1.14.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, were you using python 3.8? There was an issue with us not having a line for py38. #34667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 3.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think I didn't quite understood how build isolation works. Thanks for your quick relies!
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff