Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: pyproject.toml for Py38 #34667

Merged
merged 4 commits into from
Jun 11, 2020
Merged

Conversation

TomAugspurger
Copy link
Contributor

Closes #34666

@TomAugspurger TomAugspurger added the Build Library building on various platforms label Jun 9, 2020
@TomAugspurger TomAugspurger added this to the 1.0.5 milestone Jun 9, 2020
pyproject.toml Show resolved Hide resolved
@TomAugspurger TomAugspurger mentioned this pull request Jun 10, 2020
@TomAugspurger
Copy link
Contributor Author

Merging in a few hours if there's no objection.

@jreback
Copy link
Contributor

jreback commented Jun 11, 2020

lets merge now!

@jreback jreback merged commit 08febd2 into pandas-dev:master Jun 11, 2020
@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 15, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 08febd2b9f77fd8f943de92939788e8bc53ee2d2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #34667: BLD: pyproject.toml for Py38'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-34667-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #34667 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Source build issue with with py38
5 participants