Skip to content

ENH: storage_options for to_excel #37818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2020
Merged

ENH: storage_options for to_excel #37818

merged 1 commit into from
Nov 14, 2020

Conversation

twoertwein
Copy link
Member

@jreback jreback added Enhancement IO Excel read_excel, to_excel labels Nov 14, 2020
@jreback jreback added this to the 1.2 milestone Nov 14, 2020
@jreback jreback merged commit 3c23e6e into pandas-dev:master Nov 14, 2020
@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

thanks @twoertwein

@twoertwein
Copy link
Member Author

is there a way to re-use documentation? We have blocks about compression storage_options in many places. It would be cool to have them in one place and then import them.

@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

is there a way to re-use documentation? We have blocks about compression storage_options in many places. It would be cool to have them in one place and then import them.

yes for sure, we have the _shared_docs infrastructure, but for excel its prob enough just to use the Appenders

@alimcmaster1
Copy link
Member

@twoertwein
Copy link
Member Author

twoertwein commented Nov 14, 2020

oh yes! I think a pytest.importorskip should fix this. @alimcmaster1 Are you already making a PR?

edit: just saw your PR :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants