Skip to content

CI: Skip test when no xlwt or openpyxl #37841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Nov 14, 2020

@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Nov 14, 2020
@jreback jreback added the IO Excel read_excel, to_excel label Nov 14, 2020
@jreback jreback added this to the 1.2 milestone Nov 14, 2020
@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

thanks @alimcmaster1 merge on green.

@alimcmaster1
Copy link
Member Author

thanks @alimcmaster1 merge on green.

will do thanks!

@alimcmaster1
Copy link
Member Author

Potentially flaky test below - other issues seem fixed.

self = <pandas.tests.plotting.test_converter.TestRegistration object at 0x000001C5058A3C48>

    def test_pandas_plots_register(self):
        plt = pytest.importorskip("matplotlib.pyplot")
        s = Series(range(12), index=date_range("2017", periods=12))
        # Set to the "warn" state, in case this isn't the first test run
        with tm.assert_produces_warning(None) as w:
            s.plot()
    
>       assert len(w) == 0
E       assert 2 == 0
E        +  where 2 = len([<warnings.WarningMessage object at 0x000001C51321A188>, <warnings.WarningMessage object at 0x000001C506E39348>])

pandas\tests\plotting\test_converter.py:82: AssertionError

@alimcmaster1
Copy link
Member Author

alimcmaster1 commented Nov 14, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

its fine to merge this

@alimcmaster1 alimcmaster1 merged commit cc78408 into pandas-dev:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants