TST: add test for Index.where when needing to cast to object dtype #40888
Conversation
| @@ -248,6 +249,20 @@ def test_putmask_with_wrong_mask(self, index): | |||
| index.putmask("foo", fill) | |||
|
|
|||
|
|
|||
| class TestCasting: | |||
| def test_maybe_cast_with_dtype(self): | |||
There was a problem hiding this comment.
This test is better suited in pandas/tests/indexes/base_class/test_where.py
There was a problem hiding this comment.
The main issue was the casting so I was not sure, I could move it anyway.
There was a problem hiding this comment.
Thanks, Generally we group tests by the method calls on the particular objects (Index.where)
mroeschke
added
the
Testing
jreback
changed the title
jorisvandenbossche
changed the title
jorisvandenbossche
changed the title
There was a problem hiding this comment.
@cgarciae Thanks for the PR!
(side-note: for future reference, try to give your PRs a descriptive title; only reference the issue number is not that useful (since we don't know by heart what those numbers are about ;))
|
Thanks @jorisvandenbossche and @mroeschke for the feedback! I'll clean the PR a bit :) |
|
@jorisvandenbossche moved the test there! |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
| @@ -376,6 +376,18 @@ def test_where(self, klass, index): | |||
| result = index.where(klass(cond)) | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
| def test_maybe_cast_with_dtype(self): | |||
There was a problem hiding this comment.
can you give this a name of the form test_where_[...] ideally more desc
|
the underlying problem in #32413 was at a lower level IIRC. should we have a test on astype or a constructor? |
|
|
||
| fixed_index = index.where(cond, other) | ||
|
|
||
| tm.assert_index_equal(other, Index(["a0", "a1"])) |
There was a problem hiding this comment.
can you use
result =
expected =
tm.assert_index_equal(result, expected)
|
|
||
| fixed_index = index.where(cond, other) | ||
|
|
||
| tm.assert_index_equal(other, Index(["a0", "a1"])) |
There was a problem hiding this comment.
pls parameterize if you have multiple cases
|
closing as stale |
Hey! This is my first PR with actual code: added a very basic test to validate #32413.
Questions:
pandas/tests/indexes/test_indexing.py)indexinput argument?