Skip to content

TST: add test for Index.where when needing to cast to object dtype #40888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

TST: add test for Index.where when needing to cast to object dtype #40888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
021b80d
add TestCasting
cgarciae Apr 11, 2021
c6964c4
remove use of DataFrame + use assert_index_equal
cgarciae Apr 12, 2021
17b8d90
move test
cgarciae Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pandas/tests/indexes/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from pandas.errors import InvalidIndexError

from pandas import (
DataFrame,
DatetimeIndex,
Float64Index,
Index,
Expand Down Expand Up @@ -248,6 +249,20 @@ def test_putmask_with_wrong_mask(self, index):
index.putmask("foo", fill)


class TestCasting:
def test_maybe_cast_with_dtype(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is better suited in pandas/tests/indexes/base_class/test_where.py

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue was the casting so I was not sure, I could move it anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Generally we group tests by the method calls on the particular objects (Index.where)

# https://github.com/pandas-dev/pandas/issues/32413
frame = DataFrame(index=Index([1, np.nan]))

cond = frame.index.notna()
other = "a" + frame.reset_index().index.astype(str)

fixed_index = frame.index.where(cond, other)

assert (other == Index(["a0", "a1"])).all()
assert (fixed_index == Index([1.0, "a1"])).all()


@pytest.mark.parametrize(
"idx", [Index([1, 2, 3]), Index([0.1, 0.2, 0.3]), Index(["a", "b", "c"])]
)
Expand Down