DEPR: Int64Index, UInt64Index & Float64Index #43028

topper-123 · 2021-08-13T23:20:50Z

xref DEPR: Remove Int64Index, UInt64Index, Float64Index and Index._is_backward_compat_public_numeric_index #42717
xref ENH: NumericIndex for any numpy int/uint/float dtype #41153 & DOC: NumericIndex #42706

Deprecates Int64Index, UInt64Index & Float64Index.

I don't think it will be sensible to emit a deprecation warning for these because they have a lot of internal usage as is, so I've just added texts explaining that these are deprecated and will be removed in Pandas 2.0.

EDIT: it does now emit an deprecation warning when accessed from the main namespace. See changes to pandas.__init__.py for implementation.

>>> pd.Int64Index
FutureWarning: pandas.Int64Index is deprecated and will be removed from pandas in a future version. Use pandas.NumericIndex with the appropriate dtype instead.

mroeschke · 2021-08-14T00:14:44Z

pandas/core/indexes/numeric.py

+    Notes
+    -----
+    An NumericIndex instance can **only** contain numpy int64/32/16/8, uint64/32/16/8 or
+    float64/32/16 dtype. In Particulat, ``NumericIndex`` *can not* hold Pandas numeric


Particulat -> particular

jbrockmendel · 2021-08-14T02:11:24Z

xref #43002

lithomas1 · 2021-08-14T17:11:07Z

IMHO, we probably should emit some sort of warning to users. I'm a little worried since 2.0 should be the next release after 1.4, and this is a somewhat big change. We can always suppress the deprecation warnings internally.

topper-123 · 2021-08-17T08:21:02Z

I've made a new version where accessing Int64Index etc. in the main namespace emits a FutureWarning. So these give warnings now:

>>> import pandas as pd
>>> idx = pd.Int64Index([8, 9])
FutureWarning: pandas.Int64Index is deprecated and will be removed from pandas in a future version. Use pandas.NumericIndex with the appropriate dtype instead.
>>> isinstance(idx, pd.Int64Index)
FutureWarning: pandas.Int64Index is deprecated and will be removed from pandas in a future version. Use pandas.NumericIndex with the appropriate dtype instead.
True

but this does not:

>>> idx = pd.Index([8, 9])
>>> idx
Int64Index([8, 9], dtype='int64')
>>> isinstance(idx, pd.NumericIndex)
True

This last example doesn’t give warnings, because this access pattern is not deprecated, but will only change meaning in Pandas 2.0 (will return a NumericIndex rather than a Int64Index, + Int64Index is a subclass of NumericIndex).

These warnings should IMO give users a good hint on where they need to update their code to stay compatible in Pandas 2.0.

topper-123 · 2021-08-17T09:50:50Z

Got some failures still, but will work on them. The idea is completed, so commentd welcome.

jreback · 2021-08-19T21:36:01Z

doc/source/user_guide/advanced.rst

    In pandas 2.0, :class:`NumericIndex` will become the default index type for numeric types
    instead of ``Int64Index``, ``Float64Index`` and ``UInt64Index`` and those index types
-    will be removed. See :ref:`here <advanced.numericindex>` for more.
+    are therefore deprecated and will be removed in Pandas 2.0.


instead of saying Pandas 2.0, just a future version (we don't explicitly list the removal versions anywhere else i believe)

same comment applies to all docs below

did you push the update?

jreback · 2021-08-19T21:37:24Z

pandas/__init__.py

+__deprecated_num_index_names = ["Float64Index", "Int64Index", "UInt64Index"]
+
+
+def __dir__():


why is this needed?

This is so Int64Index etc. show up in dir calls.

Int64Index etc. have been quite prominent parts of the public API, so I think it's better that they still show up for the duration of Pandas 1.x. This should be removed in Pandas 2.0.

ok can you add a comment to this effect

topper-123 · 2021-08-21T05:35:23Z

Updated.

topper-123 · 2021-08-24T17:02:19Z

Gentle ping…

jreback

very small comment, pls rebase

doc/source/user_guide/advanced.rst

jreback · 2021-08-31T23:46:36Z

doc/source/user_guide/advanced.rst

-    will be removed.
-    ``RangeIndex`` however, will not be removed, as it represents an optimized version of an integer index.
+    instead of :class:`Int64Index`, :class:`Float64Index` and :class:`UInt64Index` and those index types
+    are therefore deprecated and will be removed in a futureversion.


future version

jreback · 2021-09-01T23:01:53Z

thanks @topper-123 very nice!

jbrockmendel · 2022-10-22T00:00:02Z

@topper-123 want to enforce this deprecation and rip out some code?

mroeschke reviewed Aug 14, 2021

View reviewed changes

topper-123 force-pushed the deprecate_old_numeric_indexes branch from fcf5cd6 to 5afecb2 Compare August 14, 2021 00:48

topper-123 force-pushed the deprecate_old_numeric_indexes branch from 098f9b0 to ce2c306 Compare August 14, 2021 08:32

lithomas1 added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Aug 14, 2021

topper-123 force-pushed the deprecate_old_numeric_indexes branch from d5a0689 to 33bb44f Compare August 19, 2021 07:46

jreback requested changes Aug 19, 2021

View reviewed changes

jreback mentioned this pull request Aug 19, 2021

DEPR: log of deprecations in 1.x (to be removed in 2.0) #30228

Closed

jreback added this to the 1.4 milestone Aug 20, 2021

jreback requested changes Aug 31, 2021

View reviewed changes

topper-123 added 14 commits September 1, 2021 19:06

DEPR: Int64Index, UInt64Index & Float64Index

ac7c6c8

add gh number

79e979c

add back attributes and methods doc string parts

1f528ea

fix test failures

ba9b33a

fix doc string

36c7f5a

add deprecation trigger in pd.__init__.py

ad2ea3c

fix errors

53346ba

fix errors

6eab0ff

fix more errors + add to whatsnew v1.4.0

84007a3

fix sphinx rst error

e0644ea

fix more errors

502386d

cleanup

8ee54a1

simplify implementation

96fa814

cleanup whatsnew/v1.4.0.rst

4cb859c

topper-123 added 2 commits September 1, 2021 19:06

remove version numbers

e84b363

spelling error

7ca2ef7

topper-123 force-pushed the deprecate_old_numeric_indexes branch from 60d16df to 7ca2ef7 Compare September 1, 2021 18:13

jreback approved these changes Sep 1, 2021

View reviewed changes

jreback merged commit 4fd0afa into pandas-dev:master Sep 1, 2021

topper-123 deleted the deprecate_old_numeric_indexes branch September 2, 2021 04:55

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021

DEPR: Int64Index, UInt64Index & Float64Index (pandas-dev#43028)

8842104

jreback mentioned this pull request Sep 15, 2021

ASV / DEPR: remove deprecated usages if possible from asv's for pd.*Index types #43586

Closed

This was referenced Jan 5, 2023

DEPR: Enforce 2.0 deprecations #50579

Closed

RLS: 2.0 #46776

Closed

topper-123 mentioned this pull request Feb 6, 2023

Include NumericIndex at top level and document it for version 2.0 #51020

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: Int64Index, UInt64Index & Float64Index #43028

DEPR: Int64Index, UInt64Index & Float64Index #43028

topper-123 commented Aug 13, 2021 •

edited

Loading

mroeschke Aug 14, 2021

topper-123 Aug 14, 2021

jbrockmendel commented Aug 14, 2021

lithomas1 commented Aug 14, 2021 •

edited

Loading

topper-123 commented Aug 17, 2021 •

edited

Loading

topper-123 commented Aug 17, 2021

jreback Aug 19, 2021

jreback Aug 19, 2021

topper-123 Aug 20, 2021

jreback Aug 20, 2021

jreback Aug 19, 2021

topper-123 Aug 20, 2021 •

edited

Loading

jreback Aug 20, 2021

topper-123 commented Aug 21, 2021

topper-123 commented Aug 24, 2021

jreback left a comment

jreback Aug 31, 2021

jreback commented Sep 1, 2021

jbrockmendel commented Oct 22, 2022

		__deprecated_num_index_names = ["Float64Index", "Int64Index", "UInt64Index"]


		def __dir__():

DEPR: Int64Index, UInt64Index & Float64Index #43028

DEPR: Int64Index, UInt64Index & Float64Index #43028

Conversation

topper-123 commented Aug 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbrockmendel commented Aug 14, 2021

lithomas1 commented Aug 14, 2021 • edited Loading

topper-123 commented Aug 17, 2021 • edited Loading

topper-123 commented Aug 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

topper-123 Aug 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

topper-123 commented Aug 21, 2021

topper-123 commented Aug 24, 2021

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Sep 1, 2021

jbrockmendel commented Oct 22, 2022

topper-123 commented Aug 13, 2021 •

edited

Loading

lithomas1 commented Aug 14, 2021 •

edited

Loading

topper-123 commented Aug 17, 2021 •

edited

Loading

topper-123 Aug 20, 2021 •

edited

Loading