Skip to content

Move moments/test_moments_rolling_*.py tests to windows/test_rolling_*.py #44141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2021
Merged

Move moments/test_moments_rolling_*.py tests to windows/test_rolling_*.py #44141

merged 2 commits into from
Oct 24, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

A part of addressing (#37535), moving some tests under the window directory.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 22, 2021
@mroeschke mroeschke added this to the 1.4 milestone Oct 23, 2021
alimcmaster1
alimcmaster1 approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke merged commit 41c96e1 into pandas-dev:master Oct 24, 2021
@mroeschke mroeschke deleted the tests/move_misc_moments branch October 24, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @alimcmaster1