Skip to content

ENH: Index[bool] #45061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Feb 5, 2022
Merged

ENH: Index[bool] #45061

merged 36 commits into from
Feb 5, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 24, 2021 •
edited
Loading

@jbrockmendel jbrockmendel mentioned this pull request Dec 27, 2021
Closed
@jreback jreback added the Index Related to the Index class or subclasses label Dec 31, 2021
@jreback
Copy link
Contributor

jreback commented Dec 31, 2021

Thoughts on deprecation path?

i think it might be ok to actually just change this, are you finding that you need to change test behavior?

@jbrockmendel
Copy link
Member Author

are you finding that you need to change test behavior?

Yes. Largely around factorize and value_counts where this branch is currently very ad-hoc.

@jbrockmendel jbrockmendel mentioned this pull request Jan 7, 2022
Merged
4 tasks
@jbrockmendel jbrockmendel changed the title ENH/WIP: Index[bool] ENH: Index[bool] Jan 7, 2022
@jbrockmendel jbrockmendel marked this pull request as ready for review January 7, 2022 22:49
@jreback jreback added this to the 1.4 milestone Jan 8, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

looks ok for 1.4?

@jbrockmendel
Copy link
Member Author

looks ok for 1.4?

I'd rather not rush it.

@jreback jreback modified the milestones: 1.4, 1.5 Jan 8, 2022
@jbrockmendel jbrockmendel marked this pull request as draft January 9, 2022 00:44
@johnzangwill johnzangwill mentioned this pull request Jan 11, 2022
Merged
3 tasks
jreback
jreback approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. ready to go?

pandas/tests/series/methods/test_drop.py Outdated
@@ -54,7 +54,9 @@ def test_drop_with_ignore_errors():

# GH 8522
ser = Series([2, 3], index=[True, False])
assert ser.index.is_object()
ser = Series([2, 3], index=[True, False])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate line here

@jbrockmendel
Copy link
Member Author

minor comment. ready to go?

just pushed with a fix. i think ready, yes.

@jreback
Copy link
Contributor

jreback commented Jan 31, 2022

can you rebase again (as the scipy fix merged)

@jbrockmendel jbrockmendel mentioned this pull request Feb 1, 2022
Merged
@jreback jreback merged commit ee6b0a0 into pandas-dev:main Feb 5, 2022
@jreback
Copy link
Contributor

jreback commented Feb 5, 2022

thanks @jbrockmendel very nice!

@jbrockmendel jbrockmendel deleted the enh-bool-index branch February 5, 2022 19:46
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jbrockmendel @phofl
ENH: Index[bool] (pandas-dev#45061)
006173c
@phobson phobson mentioned this pull request Feb 14, 2022
Closed
@ncclementi ncclementi mentioned this pull request Feb 17, 2022
Merged
3 tasks
jsignell pushed a commit to dask/dask that referenced this pull request Feb 22, 2022
@ncclementi
Fix upstream to include bool type for Index (#8732)
9558ba1 
There was pandas bug enhancement (pandas-dev/pandas#45061), that includes the possibility of a boolean Index.

In dask operations that involve `/` or `truediv` (see comment #8722 (comment)) returns a dataframe with an object-dtyped index instead. 

This PR includes includes the `idx.dtype` when registering the meta for the case of `pd.Index`
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
ENH: Index[bool] (pandas-dev#45061)
eeb6222
@phofl phofl mentioned this pull request Sep 20, 2022
Closed
2 tasks
@mroeschke mroeschke mentioned this pull request Sep 20, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Enhancement Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

API: support a BooleanIndex
3 participants
@jbrockmendel @jreback @mroeschke