closes #44914 by changing the path object to string if it is of io.BufferWriter #45480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of io.BufferedWriter type.
…unsupported-dtype
twoertwein
reviewed
Jan 20, 2022
… for typecasting to string in path object for to_parquet
|
I have added two tests:
|
jreback
approved these changes
Jan 22, 2022
|
thanks @Anirudhsekar96 |
|
This makes mypy fail:
|
3 tasks
|
I have opened a new pull request for resolving mypy fail (#45570) |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…s of io.BufferWriter (pandas-dev#45480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the path object in to_parquet to string type if it is io.BufferWriter type. PyArrow does not remove the partial file on disk if the path is not string type.