Fixes mypy attribute issue in io/parquet by adding a hasattr check #45570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Anirudhsekar96
commented
Jan 23, 2022
Anirudhsekar96
commented
- closes closes #44914 by changing the path object to string if it is of io.BufferWriter #45480, BUG: Partial file write to disk on calling to_parquet() with engine='pyarrow' with unsupported dtype #44914
- Passes tests in pytest
- Ensure all linting tests pass, see here for how to run them
twoertwein
reviewed
Jan 23, 2022
4 tasks
|
Instead of checking for Probably would also make sense to change the if condition to |
twoertwein
reviewed
Jan 23, 2022
jreback
added
IO Parquet
jreback
requested changes
Jan 23, 2022
jreback
approved these changes
Jan 23, 2022
|
@Anirudhsekar96 great ping on green |
mroeschke
requested changes
Jan 23, 2022
mroeschke
reviewed
Jan 23, 2022
mroeschke
approved these changes
Jan 23, 2022
jreback
approved these changes
Jan 23, 2022
|
great ping on green |
|
The checks have completed running |
|
Thank you @Anirudhsekar96 |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…andas-dev#45570) * Fixes mypy attribute issue in io/parquet by adding a hasattr check * changed attr to name attribute inside raw * combined the conditional checks on io.BufferedWriter in io/parquet * changed attribute from raw.name to name and added hasattr check * Skipped checks for graceful cleanup in windows * Changed checks for path object in parquet, linted and sorted imports * Removed sys dependency and changed pytest check for windows * Changed the condition in io/parquet to hasattr from isinstance of io.FileIO * Changed the pytest skip condition to decorator and added a message * Changed pytest skipif to mark.xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.