Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mypy attribute issue in io/parquet by adding a hasattr check #45570

Merged
merged 10 commits into from
Jan 23, 2022
Merged

Fixes mypy attribute issue in io/parquet by adding a hasattr check #45570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c31bbde
Fixes mypy attribute issue in io/parquet by adding a hasattr check
Anirudhsekar96 Jan 23, 2022
f2fdb3f
changed attr to name attribute inside raw
Anirudhsekar96 Jan 23, 2022
9834e85
combined the conditional checks on io.BufferedWriter in io/parquet
Anirudhsekar96 Jan 23, 2022
58d2be5
changed attribute from raw.name to name and added hasattr check
Anirudhsekar96 Jan 23, 2022
3925d51
Skipped checks for graceful cleanup in windows
Anirudhsekar96 Jan 23, 2022
54e2d9c
Changed checks for path object in parquet, linted and sorted imports
Anirudhsekar96 Jan 23, 2022
d8495d6
Removed sys dependency and changed pytest check for windows
Anirudhsekar96 Jan 23, 2022
661a222
Changed the condition in io/parquet to hasattr from isinstance of io.…
Anirudhsekar96 Jan 23, 2022
77712a9
Changed the pytest skip condition to decorator and added a message
Anirudhsekar96 Jan 23, 2022
02df442
Changed pytest skipif to mark.xfail
Anirudhsekar96 Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pandas/io/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,12 @@ def write(
mode="wb",
is_dir=partition_cols is not None,
)
if isinstance(path_or_handle, io.BufferedWriter):
path_or_handle = path_or_handle.raw.name
if (
isinstance(path_or_handle, io.BufferedWriter)
and hasattr(path_or_handle, "name")
and isinstance(path_or_handle.name, (str, bytes))
):
path_or_handle = path_or_handle.name

try:
if partition_cols is not None:
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

from pandas._config import get_option

from pandas.compat import is_platform_windows
from pandas.compat.pyarrow import (
pa_version_under2p0,
pa_version_under5p0,
Expand Down Expand Up @@ -728,6 +729,13 @@ def test_unsupported_float16(self, pa):
df = pd.DataFrame(data=data, columns=["fp16"])
self.check_external_error_on_write(df, pa, pyarrow.ArrowException)

@pytest.mark.xfail(
is_platform_windows(),
reason=(
"PyArrow does not cleanup of partial files dumps when unsupported "
"dtypes are passed to_parquet function in windows"
),
)
@pytest.mark.parametrize("path_type", [str, pathlib.Path])
def test_unsupported_float16_cleanup(self, pa, path_type):
# #44847, #44914
Expand Down