Skip to content

STYLE: Fixed redefined-outer-name linting issue #49675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

aditya-anulekh
Copy link
Contributor

@aditya-anulekh aditya-anulekh commented Nov 12, 2022

Fixed redefined-outer-name linting issue in the following files (Towards #49656)

  • pandas/core/indexes/datetimes.py
  • pandas/io/formats/xml.py
  • pandas/io/json/_table_schema.py

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, off to a good start!

@aditya-anulekh
Copy link
Contributor Author

aditya-anulekh commented Nov 12, 2022

@MarcoGorelli Addressed the requested changes in xml.py and datetimes.py. Could you please review and let me know of any required changes?

@topper-123 topper-123 added the Code Style Code style, linting, code_checks label Nov 13, 2022
@topper-123 topper-123 added this to the 2.0 milestone Nov 13, 2022
@topper-123
Copy link
Contributor

Hey @aditya-anulekh. LGTM, but needs a rebase.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aditya-anulekh !

@MarcoGorelli MarcoGorelli merged commit 2f7b42d into pandas-dev:main Nov 13, 2022
@aditya-anulekh aditya-anulekh deleted the io-redefined-outer-scope branch November 13, 2022 19:19
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
* STYLE: Fixed redefined-outer-name linting issue

* Changes in xml.py and datetimes.py addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants