PERF/CLN: let pyarrow concat chunks instead of doing it ourselves in __from_arrow__ #52928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Performance
|
LGTM pending green |
mroeschke
approved these changes
Apr 26, 2023
|
Awesome, thanks @jorisvandenbossche |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 27, 2023
…__from_arrow__ (pandas-dev#52928) * PERF: let pyarrow concat chunks instead of doing it ourselves in __from_arrow__ * workaround for empty chunked arrays for older pyarrow
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…__from_arrow__ (pandas-dev#52928) * PERF: let pyarrow concat chunks instead of doing it ourselves in __from_arrow__ * workaround for empty chunked arrays for older pyarrow
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…__from_arrow__ (pandas-dev#52928) * PERF: let pyarrow concat chunks instead of doing it ourselves in __from_arrow__ * workaround for empty chunked arrays for older pyarrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #52070 (comment) for context. We are currently manually iterating through the chunks of the pyarrow array, converting each chunk to our masked extension array, and then concatenate those at the end. While we could also let pyarrow concatenate the chunks, and then do a single conversion from the concatenated pyarrow Array to our masked array. That is both more performant and simpler to code.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.