-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: simplify pandas footer #53299
DOC: simplify pandas footer #53299
Conversation
<p class="copyright"> | ||
© {{copyright}} pandas via <a href="https://numfocus.org">NumFOCUS, Inc.</a> Hosted by <a href="https://www.ovhcloud.com">OVHcloud</a>. | ||
</p> | ||
{{footer}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of the issue is to remove this file.
|
||
|
||
html_context = { | ||
"redirects": dict(moved_api_pages), | ||
"header": header, | ||
"footer": footer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you want is to edit html_theme_options
, and specify the footer html there. My understanding is that in older pydata sphinx theme versions we could only append to the predefined footer, and now we can fully overwrite it. That's what we want to do, to have the same exact footer as now, without having to have our custom footer template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been looking for a solution to this, I'm still working on it.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Description
This pull request addresses issue #51536 by proposing a solution to simplify the pandas theme footer.
The sphinx theme currently requires an extra template to specify the footer content, which limits customization options.
For the moment there seems to be no way to get rid of the template and set everything in the config file,
However, after research and explorationI have found a potential workaround that allows us to define the footer content directly in the
conf.py
configuration file using thehtml_context
setting.Proposed Changes
conf.py
to define the footer content using thehtml_context
setting.pandas_footer.html
template to render the footer content defined inconf.py
.Your feedback and suggestions on this approach are highly appreciated.