Skip to content

WARN: Remove non-actionable warning in value_counts #54789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

WARN: Remove non-actionable warning in value_counts #54789

merged 1 commit into from
Aug 28, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 28, 2023

cc @rhshadrach maybe?

@phofl phofl added Groupby Regression Functionality that used to work in a prior pandas version Categorical Categorical Data Type labels Aug 28, 2023
@phofl phofl added this to the 2.1 milestone Aug 28, 2023
@phofl phofl mentioned this pull request Aug 28, 2023
Closed
MarcoGorelli
MarcoGorelli approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell, this is correct

@phofl phofl merged commit 94dcf24 into pandas-dev:main Aug 28, 2023
@phofl phofl deleted the value_counts branch August 28, 2023 10:35
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 28, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 28, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54789: WARN: Remove non-actionable warning in …
24b7b9c 
…value_counts
phofl added a commit that referenced this pull request Aug 28, 2023
@meeseeksmachine @phofl
Backport PR #54789 on branch 2.1.x (WARN: Remove non-actionable warni…
9ffc438 
…ng in value_counts) (#54795)

Backport PR #54789: WARN: Remove non-actionable warning in value_counts

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@rhshadrach rhshadrach mentioned this pull request Aug 29, 2023
Closed
@rhshadrach
Copy link
Member

Thanks @phofl - changes look great. Looks like we didn't have any test coverage here - I've opened #54836

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@phofl @mroeschke
WARN: Remove non-actionable warning in value_counts (pandas-dev#54789)
4e1d155
@emiliom emiliom mentioned this pull request Dec 10, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Groupby Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: Un-actionable FutureWarning in DataFrame.value_counts with categorical column(s)
3 participants
@phofl @rhshadrach @MarcoGorelli