Skip to content

WARN: Remove non-actionable warning in value_counts #54789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023
Merged

WARN: Remove non-actionable warning in value_counts #54789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7279,7 +7279,7 @@ def value_counts(
subset = self.columns.tolist()

name = "proportion" if normalize else "count"
counts = self.groupby(subset, dropna=dropna).grouper.size()
counts = self.groupby(subset, dropna=dropna, observed=False).grouper.size()
counts.name = name

if sort:
Expand Down
14 changes: 14 additions & 0 deletions pandas/tests/frame/methods/test_value_counts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,3 +175,17 @@ def test_data_frame_value_counts_subset(nulls_fixture, columns):
)

tm.assert_series_equal(result, expected)


def test_value_counts_categorical_future_warning():
# GH#54775
df = pd.DataFrame({"a": [1, 2, 3]}, dtype="category")
result = df.value_counts()
expected = pd.Series(
1,
index=pd.MultiIndex.from_arrays(
[pd.Index([1, 2, 3], name="a", dtype="category")]
),
name="count",
)
tm.assert_series_equal(result, expected)