Skip to content

Conversation

jbrockmendel
Copy link
Member

No description provided.

@mroeschke mroeschke added Internals Related to non-user accessible pandas implementation Deprecate Functionality to remove in pandas labels Oct 2, 2023
@mroeschke
Copy link
Member

Are you aware of any libraries using this?

@jbrockmendel
Copy link
Member Author

Are you aware of any libraries using this?

@phofl says dask is using it

@phofl
Copy link
Member

phofl commented Oct 2, 2023

Yep, I’d prefer not to deprecate

@jbrockmendel
Copy link
Member Author

im pretty set on this; we need to ween dask and anyone else off of internals in general if we want to be able to change anything. in particular i want to get the axes out of the Managers

@phofl
Copy link
Member

phofl commented Oct 2, 2023

We are serializing/de-serializing the blocks. I am open to do this differently though, but not sure if there is an efficient way of doing this

@jbrockmendel
Copy link
Member Author

We are serializing/de-serializing the blocks. I am open to do this differently though, but not sure if there is an efficient way of doing this

Create a DataFrame for each block and concat them?

@phofl
Copy link
Member

phofl commented Oct 2, 2023

Can we offer a private api for this maybe? List of blocks and axes?

@jbrockmendel
Copy link
Member Author

Can we offer a private api for this maybe? List of blocks and axes?

After this PR dask can get continue to import the function from internals.api which is explicitly pseudo-public for pyarrow/dask. This PR is just getting the function to the more-correct place.

Long-term, no. dask and anyone else need to stop using Blocks/Managers directly.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants