CLN: enforce the deprecation of exposing blocks in core.internals #58467
Conversation
mroeschke
added
Internals
pandas/tests/io/test_parquet.py
Outdated
| if Version(pyarrow.__version__) == "10.0.1": | ||
| pytest.skip("skip the pyarrow version '10.0.1'") |
There was a problem hiding this comment.
| if Version(pyarrow.__version__) == "10.0.1": | |
| pytest.skip("skip the pyarrow version '10.0.1'") | |
| pytest.importorskip("pyarrow", "10.0.1") |
And similar below
There was a problem hiding this comment.
thanks for your help. It seems that it doesn't work when using pytest.importorskip("pyarrow", "10.0.1"), but it works properly with pytest.importorskip("pyarrow", "11.0.0")
|
Thanks @natmokval |
…ndas-dev#58467) * CLN: enforce the deprecation of exposing blocks in core.internals * remove the function __getattr__, and entries from __all__ * fix mypy error * add a note to v3.0.0 * skip parquet tests for minimum Pyarrow version * fixup test_basic * fix pre-commit error * skip pyarrow=10.0.1 in test_parquet.py * fix mypy error * fix pre-commit error * fixup test_parquet.py * fix pre-commit error * fixup test_parquet.py * replacee pytest.skip with pytest.importorskip * skip pyarrow '10.0.1'
|
I think we need to revert this, and first bump the DeprecationWarning to a FutureWarning. I actually don't care that much about the exact warning class, though, but I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning. But I think we should care about keeping this around a bit longer (even though it is with a warning), because this simply means that you cannot use pandas 3.0 with pyarrow < 15, while we actually have a minimum version requirement of pyarrow 10 |
Which is similarly as Richard said in #50578 (comment) |
thanks @jorisvandenbossche, I opened PR to revert this |
xref #55355,
enforced the deprecation of
create_block_manager_from_blocksxref #55139
enforced the deprecation of exposing
blocksincore.internals