CLN: Change assert_(a in b) and assert_(a not in b) to specialized forms #6381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on #6175. Changes instances of assert_(a [not] in b) to specialized assert[Not]In(a,b).
|
Uses new functions added in #6376. Specialized functions should be drop-in replaceable (including named arguments) for the assertions added in 2.7. |
|
@bwignall another thing that maybe should be done is change the usage of |
jreback
added a commit
that referenced
this pull request
Feb 17, 2014
CLN: Change assert_(a in b) and assert_(a not in b) to specialized forms
|
@jreback, I'll chew on it. That would touch ~1400 lines in the various tests. I will look through them and think about organization. On the testing docs, @KTAtkinson may be working on that at the moment, as per #6321; if nothing crops up soon, I'll take a crack at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #6175. Changes instances of assert_(a [not] in b) to specialized assert[Not]In(a,b).