Skip to content

CLN: Change assert_(a in b) and assert_(a not in b) to specialized forms #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def setUp(self):
def test_shallow_copying(self):
original = self.container.copy()
assert_isinstance(self.container.view(), FrozenNDArray)
self.assert_(not isinstance(self.container.view(np.ndarray), FrozenNDArray))
self.assertFalse(isinstance(self.container.view(np.ndarray), FrozenNDArray))
self.assertIsNot(self.container.view(), self.container)
self.assert_numpy_array_equal(self.container, original)
# shallow copy should be the same too
Expand Down
24 changes: 12 additions & 12 deletions pandas/tests/test_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,15 @@ def test_repr_truncation(self):

for line, value in lzip(r.split('\n'), df['B']):
if _strlen(value) + 1 > max_len:
self.assert_('...' in line)
self.assertIn('...', line)
else:
self.assert_('...' not in line)
self.assertNotIn('...', line)

with option_context("display.max_colwidth", 999999):
self.assert_('...' not in repr(df))
self.assertNotIn('...', repr(df))

with option_context("display.max_colwidth", max_len + 2):
self.assert_('...' not in repr(df))
self.assertNotIn('...', repr(df))

def test_repr_chop_threshold(self):
df = DataFrame([[0.1, 0.5],[0.5, -0.1]])
Expand Down Expand Up @@ -831,7 +831,7 @@ def test_wide_repr_named(self):
self.assert_(len(wider_repr) < len(wide_repr))

for line in wide_repr.splitlines()[1::13]:
self.assert_('DataFrame Index' in line)
self.assertIn('DataFrame Index', line)

reset_option('display.expand_frame_repr')

Expand All @@ -855,7 +855,7 @@ def test_wide_repr_multiindex(self):
self.assert_(len(wider_repr) < len(wide_repr))

for line in wide_repr.splitlines()[1::13]:
self.assert_('Level 0 Level 1' in line)
self.assertIn('Level 0 Level 1', line)

reset_option('display.expand_frame_repr')

Expand Down Expand Up @@ -1251,7 +1251,7 @@ def test_to_html_with_no_bold(self):

def test_to_html_columns_arg(self):
result = self.frame.to_html(columns=['A'])
self.assert_('<th>B</th>' not in result)
self.assertNotIn('<th>B</th>', result)

def test_to_html_multiindex(self):
columns = pandas.MultiIndex.from_tuples(list(zip(np.arange(2).repeat(2),
Expand Down Expand Up @@ -1417,13 +1417,13 @@ def test_to_html_index(self):
index=index)
result = df.to_html(index=False)
for i in index:
self.assert_(i not in result)
self.assertNotIn(i, result)

tuples = [('foo', 'car'), ('foo', 'bike'), ('bar', 'car')]
df.index = pandas.MultiIndex.from_tuples(tuples)
result = df.to_html(index=False)
for i in ['foo', 'bar', 'car', 'bike']:
self.assert_(i not in result)
self.assertNotIn(i, result)

def test_repr_html(self):
self.frame._repr_html_()
Expand Down Expand Up @@ -1578,7 +1578,7 @@ def get_ipython():

fmt.set_option('display.max_rows', 5, 'display.max_columns', 2)
repstr = self.frame._repr_html_()
self.assert_('class' in repstr) # info fallback
self.assertIn('class', repstr) # info fallback

fmt.reset_option('^display.')

Expand Down Expand Up @@ -1888,9 +1888,9 @@ def test_float_trim_zeros(self):
if line.startswith('dtype:'):
continue
if _three_digit_exp():
self.assert_('+010' in line)
self.assertIn('+010', line)
else:
self.assert_('+10' in line)
self.assertIn('+10', line)

def test_datetimeindex(self):

Expand Down
62 changes: 31 additions & 31 deletions pandas/tests/test_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def test_getitem(self):
for key, _ in compat.iteritems(self.frame._series):
self.assert_(self.frame[key] is not None)

self.assert_('random' not in self.frame)
self.assertNotIn('random', self.frame)
with assertRaisesRegexp(KeyError, 'no item named random'):
self.frame['random']

Expand Down Expand Up @@ -399,7 +399,7 @@ def test_setitem(self):
# not sure what else to do here
series = self.frame['A'][::2]
self.frame['col5'] = series
self.assert_('col5' in self.frame)
self.assertIn('col5', self.frame)
tm.assert_dict_equal(series, self.frame['col5'],
compare_keys=False)

Expand Down Expand Up @@ -551,7 +551,7 @@ def test_setitem_corner(self):
index=np.arange(3))
del df['B']
df['B'] = [1., 2., 3.]
self.assert_('B' in df)
self.assertIn('B', df)
self.assertEqual(len(df.columns), 2)

df['A'] = 'beginning'
Expand Down Expand Up @@ -2060,7 +2060,7 @@ def test_set_index_nonuniq(self):
'E': np.random.randn(5)})
with assertRaisesRegexp(ValueError, 'Index has duplicate keys'):
df.set_index('A', verify_integrity=True, inplace=True)
self.assert_('A' in df)
self.assertIn('A', df)

def test_set_index_bug(self):
# GH1590
Expand Down Expand Up @@ -2287,7 +2287,7 @@ def test_constructor_dict(self):
columns=['col2', 'col3', 'col4'])

self.assertEqual(len(frame), len(self.ts2))
self.assert_('col1' not in frame)
self.assertNotIn('col1', frame)
self.assert_(isnull(frame['col3']).all())

# Corner cases
Expand Down Expand Up @@ -3810,7 +3810,7 @@ def test_from_records_to_records(self):

records = indexed_frame.to_records(index=False)
self.assertEqual(len(records.dtype.names), 2)
self.assert_('index' not in records.dtype.names)
self.assertNotIn('index', records.dtype.names)

def test_from_records_nones(self):
tuples = [(1, 2, None, 3),
Expand Down Expand Up @@ -4007,16 +4007,16 @@ def test_to_recods_index_name(self):
df = DataFrame(np.random.randn(3, 3))
df.index.name = 'X'
rs = df.to_records()
self.assert_('X' in rs.dtype.fields)
self.assertIn('X', rs.dtype.fields)

df = DataFrame(np.random.randn(3, 3))
rs = df.to_records()
self.assert_('index' in rs.dtype.fields)
self.assertIn('index', rs.dtype.fields)

df.index = MultiIndex.from_tuples([('a', 'x'), ('a', 'y'), ('b', 'z')])
df.index.names = ['A', None]
rs = df.to_records()
self.assert_('level_0' in rs.dtype.fields)
self.assertIn('level_0', rs.dtype.fields)

def test_join_str_datetime(self):
str_dates = ['20120209', '20120222']
Expand Down Expand Up @@ -4340,7 +4340,7 @@ def test_repr_column_name_unicode_truncation_bug(self):
' the File through the code..')})

result = repr(df)
self.assert_('StringCol' in result)
self.assertIn('StringCol', result)

def test_head_tail(self):
assert_frame_equal(self.frame.head(), self.frame[:5])
Expand Down Expand Up @@ -4404,17 +4404,17 @@ def test_insert(self):

def test_delitem(self):
del self.frame['A']
self.assert_('A' not in self.frame)
self.assertNotIn('A', self.frame)

def test_pop(self):
self.frame.columns.name = 'baz'

A = self.frame.pop('A')
self.assert_('A' not in self.frame)
self.assertNotIn('A', self.frame)

self.frame['foo'] = 'bar'
foo = self.frame.pop('foo')
self.assert_('foo' not in self.frame)
self.assertNotIn('foo', self.frame)
# TODO self.assertEqual(self.frame.columns.name, 'baz')

def test_pop_non_unique_cols(self):
Expand Down Expand Up @@ -5162,7 +5162,7 @@ def test_combineSeries(self):

for key, s in compat.iteritems(self.frame):
assert_series_equal(larger_added[key], s + series[key])
self.assert_('E' in larger_added)
self.assertIn('E', larger_added)
self.assert_(np.isnan(larger_added['E']).all())

# vs mix (upcast) as needed
Expand Down Expand Up @@ -6473,7 +6473,7 @@ def test_deepcopy(self):
def test_copy(self):
cop = self.frame.copy()
cop['E'] = cop['A']
self.assert_('E' not in self.frame)
self.assertNotIn('E', self.frame)

# copy objects
copy = self.mixed_frame.copy()
Expand Down Expand Up @@ -6614,10 +6614,10 @@ def test_corrwith(self):

dropped = a.corrwith(b, axis=0, drop=True)
assert_almost_equal(dropped['A'], a['A'].corr(b['A']))
self.assert_('B' not in dropped)
self.assertNotIn('B', dropped)

dropped = a.corrwith(b, axis=1, drop=True)
self.assert_(a.index[-1] not in dropped.index)
self.assertNotIn(a.index[-1], dropped.index)

# non time-series data
index = ['a', 'b', 'c', 'd', 'e']
Expand Down Expand Up @@ -8327,7 +8327,7 @@ def test_reindex_columns(self):

assert_series_equal(newFrame['B'], self.frame['B'])
self.assert_(np.isnan(newFrame['E']).all())
self.assert_('C' not in newFrame)
self.assertNotIn('C', newFrame)

# length zero
newFrame = self.frame.reindex(columns=[])
Expand Down Expand Up @@ -8885,15 +8885,15 @@ def test_rename_nocopy(self):

def test_rename_inplace(self):
self.frame.rename(columns={'C': 'foo'})
self.assert_('C' in self.frame)
self.assert_('foo' not in self.frame)
self.assertIn('C', self.frame)
self.assertNotIn('foo', self.frame)

c_id = id(self.frame['C'])
frame = self.frame.copy()
frame.rename(columns={'C': 'foo'}, inplace=True)

self.assert_('C' not in frame)
self.assert_('foo' in frame)
self.assertNotIn('C', frame)
self.assertIn('foo', frame)
self.assertNotEqual(id(frame['foo']), c_id)

def test_rename_bug(self):
Expand Down Expand Up @@ -9424,11 +9424,11 @@ def test_filter(self):
# items
filtered = self.frame.filter(['A', 'B', 'E'])
self.assertEqual(len(filtered.columns), 2)
self.assert_('E' not in filtered)
self.assertNotIn('E', filtered)

filtered = self.frame.filter(['A', 'B', 'E'], axis='columns')
self.assertEqual(len(filtered.columns), 2)
self.assert_('E' not in filtered)
self.assertNotIn('E', filtered)

# other axis
idx = self.frame.index[0:4]
Expand All @@ -9442,7 +9442,7 @@ def test_filter(self):

filtered = fcopy.filter(like='A')
self.assertEqual(len(filtered.columns), 2)
self.assert_('AA' in filtered)
self.assertIn('AA', filtered)

# like with ints in column names
df = DataFrame(0., index=[0, 1, 2], columns=[0, 1, '_A', '_B'])
Expand All @@ -9455,7 +9455,7 @@ def test_filter(self):

# objects
filtered = self.mixed_frame.filter(like='foo')
self.assert_('foo' in filtered)
self.assertIn('foo', filtered)

# unicode columns, won't ascii-encode
df = self.frame.rename(columns={'B': u('\u2202')})
Expand All @@ -9469,7 +9469,7 @@ def test_filter_regex_search(self):
# regex
filtered = fcopy.filter(regex='[A]+')
self.assertEqual(len(filtered.columns), 2)
self.assert_('AA' in filtered)
self.assertIn('AA', filtered)

# doesn't have to be at beginning
df = DataFrame({'aBBa': [1, 2],
Expand Down Expand Up @@ -10821,10 +10821,10 @@ def test_reindex_boolean(self):

def test_reindex_objects(self):
reindexed = self.mixed_frame.reindex(columns=['foo', 'A', 'B'])
self.assert_('foo' in reindexed)
self.assertIn('foo', reindexed)

reindexed = self.mixed_frame.reindex(columns=['A', 'B'])
self.assert_('foo' not in reindexed)
self.assertNotIn('foo', reindexed)

def test_reindex_corner(self):
index = Index(['a', 'b', 'c'])
Expand Down Expand Up @@ -10903,8 +10903,8 @@ def test_reindex_multi(self):

def test_rename_objects(self):
renamed = self.mixed_frame.rename(columns=str.upper)
self.assert_('FOO' in renamed)
self.assert_('foo' not in renamed)
self.assertIn('FOO', renamed)
self.assertNotIn('foo', renamed)

def test_fill_corner(self):
self.mixed_frame['foo'][5:20] = nan
Expand Down
6 changes: 3 additions & 3 deletions pandas/tests/test_groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -2047,14 +2047,14 @@ def test_groupby_series_with_name(self):
result = self.df.groupby(self.df['A']).mean()
result2 = self.df.groupby(self.df['A'], as_index=False).mean()
self.assertEquals(result.index.name, 'A')
self.assert_('A' in result2)
self.assertIn('A', result2)

result = self.df.groupby([self.df['A'], self.df['B']]).mean()
result2 = self.df.groupby([self.df['A'], self.df['B']],
as_index=False).mean()
self.assertEquals(result.index.names, ('A', 'B'))
self.assert_('A' in result2)
self.assert_('B' in result2)
self.assertIn('A', result2)
self.assertIn('B', result2)

def test_groupby_nonstring_columns(self):
df = DataFrame([np.arange(10) for x in range(10)])
Expand Down
Loading