Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xarray version #538

Closed
wants to merge 1 commit into from
Closed

Conversation

jbusecke
Copy link

I experienced problems with a computation due to a bug that was recently solved in xarray (pydata/xarray#3574 (comment)). This PR adds the most recent release of xarray

I experienced problems with a computation due to a bug that was recently solved in xarray (pydata/xarray#3574 (comment)). This PR adds the most recent release of xarray
@rabernat
Copy link
Member

Thanks for this Julius. I would slightly prefer to update this in pangeo-stacks. I would prefer to keep ocean's image as close as possible to the default pangeo notebook image.

https://github.com/pangeo-data/pangeo-stacks/blob/master/pangeo-notebook/binder/environment.yml

Instead, we should update pangeo-stacks and then change this:

# Note that there must be a tag
FROM pangeo/pangeo-notebook-onbuild:2019.12.08

@rabernat
Copy link
Member

p.s. I know this is confusing. Sorry that it's all so unclear.

@jbusecke
Copy link
Author

Would it be possible to just rebuild? I think this conda should resolve to the newest xarray by default?

@tjcrone
Copy link
Contributor

tjcrone commented Feb 12, 2020

@jbusecke, the most recent builds of the pangeo-notebook image have xarray=0.15. @scottyhq and @jhamman have been working on transitioning the pangeo-stacks CI from Travis to GitHub actions, and I'm not quite sure where that process stands. But I'm sure that when this process is complete they will bump the notebook image and you will have 0.15. @scottyhq, is this something that you foresee happening soon?

@scottyhq
Copy link
Member

Yes, the new images are being built with recent versions, so you can change the Dockerfile to
the most recent by checking https://hub.docker.com/r/pangeo/pangeo-notebook-onbuild/tags :
FROM pangeo/pangeo-notebook-onbuild:2020.02.08-906577d

Note with the new CI building you can get the full list of packages and versions by looking at the "MasterBuild" workflow for the commit number (906577d) https://github.com/pangeo-data/pangeo-stacks/actions

Screenshot 2020-02-11 16 49 03

Screenshot 2020-02-11 16 49 27

@jbusecke
Copy link
Author

I just checked on ocean.pangeo.io, and I still have v0.14.1 over there.
Is there another deployment that I could use until ocean is updated (Trying to make an updated plot for next weeks Ocean Science Meeting hehe)?

Thanks for all the explanations btw. I am still relatively new to the whole cloud part of pangeo and learning a lot.

@scottyhq
Copy link
Member

scottyhq commented Feb 12, 2020

@jbusecke - hydro.pangeo.io is also running on google cloud. and has the latest image:

'display_name': 'Pangeo Env - standard (n1-highmem-4 | 4 cores, 24GB)',
'kubespawner_override': {
'cpu_limit': 4,
'cpu_guarantee': 4,
'mem_limit': '24G',
'mem_guarantee': '24G',
'image': 'pangeo/pangeo-notebook:latest',

Be sure to select "Pangeo Env" when you log in

@scottyhq
Copy link
Member

@rabernat - I want to make sure you are aware that the latest pangeo-notebook does not currently have some of the previous ML-related libraries (which are in now in the separate pangeo-ml) image.

https://github.com/pangeo-data/pangeo-stacks/blob/906577da67cc0c59130412990e1df0cdde2b352e/pangeo-notebook/binder/environment.yml#L17-L20

A few domain specific packages also were commented out due to build errors
pangeo-data/pangeo-stacks#118 (comment)

So you may either want to switch your ocean base image to pangeo-ml or create a pull request in pangeo-stacks to try rebuilding with those libraries re-enabled.

@jbusecke
Copy link
Author

I will go ahead and close this. Ill use hydro for now and hopefully the next build will include this on ocean. Thanks for the help.

@jbusecke jbusecke closed this Feb 25, 2020
@jbusecke jbusecke reopened this Feb 26, 2020
@jbusecke jbusecke closed this Feb 26, 2020
@jbusecke
Copy link
Author

@scottyhq It seems like the version on hydro.pangeo.io is now 14.1 again! I did check yesterday and it was 0.15. was this downgraded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants