CRITICAL (runtime:1128) - Exception in thread named 'extract_embedded_sub' (most recent call last)

[cphmichael]

After I created issue #680 I clicked "Extract stream 2" in Kitana, but after waiting 30 sec. there was no external subtitles and Kitana still says "No current subtitles in storage".

I took a new look in the SZ log and there are errors, so I hope that give you a hint about what is wrong :-)

com.plexapp.agents.subzero.log

[pannal]

Yeah well, it's not clear to SZ how it should extract that subtitle. You don't have Embedded streams: Treat "Undefined" (und) as language 1 on, right?
It can't really store a subtitle without the language attribute.

[cphmichael]

I have just checked, and this option is on.

[pannal]

Can you try the latest develop-2.6 and see whether that fixes your issue?

[cphmichael]

2.6.5.3152 DEV solved the .ASS problem for Mr. Robot :-)

So you found an error in the code?

Before I changed to the new DEV, Sonarr uploaded Succession S2E09 with embedded .ASS

SZ was able to extract the subtitles for this one. So something must be different between the embedded .ASS for Mr. Robot and Succession.

I think your fix solved 680 and 681

[pannal]

I guess the embedded subtitle in Succession had a language tag set.

[cphmichael]

As you can see on the attached screen dump, Succession also says Unknown (ASS)

I received Succession yesterday but I first installed your fix this morning, so it is strange that SZ was able to extract the .ASS subtitles for Succession but not Mr. Robot.

But now you have fixed the Mr. Robot problem, so maybe it is not so interesting to use time to find the reason why it worked :-)

[pannal]

It seems like I didn't properly push the last fix. Can you try again?

[cphmichael]

I have installed 2.6.5.3161 DEV, but SZ has extracted the embedded .ASS since 2.6.5.3152 DEV, so I can not test the changes you have made to the new DEV version.