Prefer require_relative for internal requires #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side note, this change has been approved here by
@deivid-rodriguez
which is familiar with this issue: activeadmin/arbre#622require_relative
is preferred overrequire
for files within the sameproject because it uses paths relative to the current file, making code
more portable and less dependent on the load path.
This change updates internal requires to use
require_relative
forconsistency, performance, and improved portability.
Ref:
require_relative
for internal requires ruby/psych#522require_relative
rubocop/rubocop#8748Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.md
and update this PRIf this change merits an update toCHANGELOG.md
, add an entry following Keep a Changelog guidelines with semantic versioning