Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compsoser.json with fixed license version #236

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

jazzsequence
Copy link
Contributor

Some packagist builds are failing because of composer.json linting issues from the way the license was written in our composer.json. This update fixes it to spdx.org standards.

@jazzsequence jazzsequence requested a review from a team as a code owner February 2, 2023 21:08
@jazzsequence jazzsequence self-assigned this Feb 2, 2023
pwtyler
pwtyler previously approved these changes Feb 2, 2023
@pwtyler
Copy link
Member

pwtyler commented Feb 2, 2023

LGTM given passing tests which I assume are unrelated.

@jazzsequence jazzsequence merged commit 9aac4e1 into develop Feb 2, 2023
@jazzsequence jazzsequence deleted the update-compsoser-json branch February 2, 2023 21:19
jazzsequence added a commit that referenced this pull request Feb 7, 2023
* Update images for lint and test-behat jobs

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#229)

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [CMSP-79] PHP 8.2 (#232)

* Bump grunt from 1.5.3 to 1.6.1 (#235)

* fix GPL license version (#236)

* Add CMS Platform to CODEOWNERS (#239)

* [BUGS-5809] Add fallback for $session->get_data() (#237)

* fix GPL license version

* add a fallback
if $session is not null but the ->get_data is this creates a PHP warning
It's possible this might escallate to a fatal in PHP 8+
Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/

* exclude short ternaries being disallowed
I fundamentally disagree with the guidance that they are "rarely used
correctly"

* bump version

* update/add changelog

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: John Spellman <john.spellman@pantheon.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jazzsequence added a commit that referenced this pull request Apr 7, 2023
* Update images for lint and test-behat jobs

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#229)

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [CMSP-79] PHP 8.2 (#232)

* Bump grunt from 1.5.3 to 1.6.1 (#235)

* fix GPL license version (#236)

* Add CMS Platform to CODEOWNERS (#239)

* [BUGS-5809] Add fallback for $session->get_data() (#237)

* fix GPL license version

* add a fallback
if $session is not null but the ->get_data is this creates a PHP warning
It's possible this might escallate to a fatal in PHP 8+
Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/

* exclude short ternaries being disallowed
I fundamentally disagree with the guidance that they are "rarely used
correctly"

* bump version

* update/add changelog

* Remove gruntfile and package.json (#243)

The only thing this was being used for was a readme to markdown script that we're not using.

* Update the "necessary assets" step (#242)

* Update the "necessary assets" step

Replace "Confirm that the necessary assets are present in the newly created tag, and test on a WP install if desired" with the actual step for this repository.

* call out .gitattributes, specifically

Co-authored-by: John Spellman <john.spellman@pantheon.io>

* remove extra number list item

---------

Co-authored-by: John Spellman <john.spellman@pantheon.io>

* Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 (#245)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bump version & update changelog

* add john to contributors

* explicitly define which symfony/yaml to use

* update composer so it pulls the right symfony/yaml

* we actually shouldn't need to define symfony/yaml
if we do a composer update before install for 7.4 tests

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: John Spellman <john.spellman@pantheon.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants