Release 1.3.5 #246
Merged
Release 1.3.5 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CMS-1141] Update images for lint and test-behat jobs
….0 (#229) Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0. - [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases) - [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator) - [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0) --- updated-dependencies: - dependency-name: dealerdirect/phpcodesniffer-composer-installer dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix GPL license version * add a fallback if $session is not null but the ->get_data is this creates a PHP warning It's possible this might escallate to a fatal in PHP 8+ Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/ * exclude short ternaries being disallowed I fundamentally disagree with the guidance that they are "rarely used correctly"
The only thing this was being used for was a readme to markdown script that we're not using.
* Update the "necessary assets" step Replace "Confirm that the necessary assets are present in the newly created tag, and test on a WP install if desired" with the actual step for this repository. * call out .gitattributes, specifically Co-authored-by: John Spellman <john.spellman@pantheon.io> * remove extra number list item --------- Co-authored-by: John Spellman <john.spellman@pantheon.io>
Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases) - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md) - [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5) --- updated-dependencies: - dependency-name: yoast/phpunit-polyfills dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
if we do a composer update before install for 7.4 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in
mainand resolves conflicts. Worth noting that we had amasterbranch that was actually more up-to-date thanmain. I've done some branch pruning to avoid this in the future.This also updates the CircleCI build for the 7.4 tests to run a
composer updatebefore thecomposer installwhich we've had to do elsewhere so that the install doesn't fail due to dependencies that require PHP 8.Also adds @jspellman814 as a contributor.