fix: customer reported that sometimes box_parse_additional_details could raise an error when trying to json.loads #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2022 16:06
…uld raise an error when trying to json.loads
calkim-panther
previously approved these changes
Sep 27, 2022
added 3 commits
September 27, 2022 09:41
darwayne
previously requested changes
Sep 29, 2022
There was a problem hiding this comment.
based on @lindsey-w's latest internal feedback we should move away from introducing panther-core as a dependency
|
|
||
| ## NOTE: WE DO NOT WANT TO IMPORT panther_analysis_tool into any detection | ||
| # we need the types from panther_analysis_tool for unit testing sometimes, though | ||
| from panther_core.immutable import ImmutableCaseInsensitiveDict, ImmutableList |
There was a problem hiding this comment.
based on in internal discussion we want to avoid introducing panther_core as dependency to panther-analysis
added 3 commits
September 29, 2022 09:55
…b.com/panther-labs/panther-analysis into fix/edyesed/box_helpers_caseimmutable
|
@darwayne + @lindsey-w , I believe this is what the internal discussion said we should do |
added 2 commits
September 29, 2022 09:59
…b.com/panther-labs/panther-analysis into fix/edyesed/box_helpers_caseimmutable
darwayne
reviewed
Sep 29, 2022
There was a problem hiding this comment.
This looks right to me, would like to get additional verification from @lindsey-w
lindsey-w
reviewed
Sep 29, 2022
| @@ -9,6 +9,9 @@ deps: | |||
| deps-update: | |||
| pipenv update | |||
|
|
|||
| global-helpers-unit-test: | |||
| pipenv run python global_helpers/*_test.py | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
sometimes
event['additional_details']is typed to not-a-string when processing box events.json.loads()wanted a string-ish input.Changes
panther_base_helpers.box_parse_additional_detailsand provides a feature-equivalent alternative result set, if the TypeError is for one of the panther ImmutableXXX types.Testing
global_helpers/*_test.py( note: it only works as long as there's a single file matching the pattern ).ATTN: @panther-labs/detections for extra 👀