Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customer reported that sometimes box_parse_additional_details could raise an error when trying to json.loads #516

Merged
merged 13 commits into from
Sep 29, 2022
Merged

fix: customer reported that sometimes box_parse_additional_details could raise an error when trying to json.loads #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
62791ed
fix: customer reported that sometimes box_parse_additional_details co…
Sep 26, 2022
9cf515c
fix: panther_base_helpers better shortened as p_b_h and not p_h_b
Sep 26, 2022
5dfbc99
chore: take the linters advice
Sep 26, 2022
8342663
Merge branch 'master' into fix/edyesed/box_helpers_caseimmutable
Sep 27, 2022
5068b46
chore: typecheck additional_details in the box helpers
Sep 27, 2022
d447a9e
Merge branch 'fix/edyesed/box_helpers_caseimmutable' of https://githu…
Sep 27, 2022
f45a6f5
Merge branch 'master' into fix/edyesed/box_helpers_caseimmutable
Sep 27, 2022
6a9ed30
fix: handle the type of box's additional_details in a different way
Sep 29, 2022
a3b3169
Merge branch 'fix/edyesed/box_helpers_caseimmutable' of https://githu…
Sep 29, 2022
74832fc
Merge branch 'master' into fix/edyesed/box_helpers_caseimmutable
Sep 29, 2022
bdb8b90
fix: always run make test locally before pushing to origin
Sep 29, 2022
34655e7
Merge branch 'fix/edyesed/box_helpers_caseimmutable' of https://githu…
Sep 29, 2022
1bfde51
chore: ... and make fmt
Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ deps:
deps-update:
pipenv update

global-helpers-unit-test:
pipenv run python global_helpers/*_test.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++


lint: lint-pylint lint-fmt

lint-pylint:
Expand All @@ -35,6 +38,6 @@ fmt:
install:
pipenv install --dev

test:
test: global-helpers-unit-test
pipenv run panther_analysis_tool test

Loading