Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to Pants 2.0.0.dev9 #38

Merged
merged 3 commits into from
Aug 21, 2020
Merged

upgrade to Pants 2.0.0.dev9 #38

merged 3 commits into from
Aug 21, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Aug 20, 2020

No description provided.

Eric-Arellano
Eric-Arellano approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tdyas
Copy link
Contributor Author

tdyas commented Aug 20, 2020

@Eric-Arellano: Build is failing with Exception: Unmatched glob from file arguments: "helloworld/main_pb2.py". Is that from a change in dev9?

@Eric-Arellano
Copy link
Contributor

Oof. Apparently I merged dev8 on red. My bad. In .travis.yml, chang _pb2.py to _py2.py. Typo in the file arg.

@asherf
Copy link
Member

asherf commented Aug 20, 2020

Screen Shot 2020-08-20 at 8 14 28 AM

@benjyw
Copy link
Contributor

benjyw commented Aug 20, 2020

Note: typo and py2 constraint issues fixed in #39

@tdyas
Copy link
Contributor Author

tdyas commented Aug 21, 2020 •
edited
Loading

Latest build failure:

pex.vendor._vendored.setuptools.pkg_resources.ContextualVersionConflict: (importlib-resources 3.0.0 (/home/travis/.pex/installed_wheels/356a69e89b60e58a9f454fae2aa19f4e0501c768/importlib_resources-3.0.0-py2.py3-none-any.whl), Requirement.parse('importlib-resources<2,>=1.0; python_version < "3.7"'), set(['virtualenv']))

I only understand that this exception is probably something wrong with constraints. It tells me nothing about how to resolve it though. We need a better error message for this.

@Eric-Arellano Eric-Arellano merged commit 5102d8d into pantsbuild:2.0 Aug 21, 2020
@Eric-Arellano
Copy link
Contributor

Thanks!

@tdyas tdyas deleted the upgrade_to_2.0.0.dev9 branch August 21, 2020 06:53
asherf added a commit to toolchainlabs/example-python that referenced this pull request Nov 13, 2020
@asherf @danieljanes
@benjyw @Eric-Arellano @tdyas @stuhood
Merge from pants repo upstream. (#17)
764e515 
* Update `pants` and `pants.toml` for 2.0 release (#26)

* Fix the setup-py part of the example. (#30)

Required moving the .proto files to be
below the exported target (in the filesystem
sense).

If we support setting a source root on
generated protos in the future, we can
modify this further to demo that.

* Upgrade to 2.0.0.dev7 (pantsbuild#33)

Remaining followups:

* [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI.
* [ ] Turn on dependency inference. Needs docs update.
* [ ] Enable MyPy.
* [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update.
* [ ] Use `resolve_all_constraints`. Needs docs update.
* [ ] Fix all references to readme.io. Fix the `master` branch too.
* [ ] Update the `./pants` script. Fix the `master` branch too.

* Update doc URLs to pantsbuild.org (pantsbuild#35)

* Upgrade to 2.0.0.dev8 (pantsbuild#37)

* Add py2 __init__.py files. (pantsbuild#39)

Otherwise `./pants run helloworld:helloworld_py2` doesn't work.

* Upgrade to Pants 2.0.0.dev9 (pantsbuild#38)

* Upgrade to 2.0.0b0 (pantsbuild#40)

* Turn on dependency inference (pantsbuild#41)

* update ./pants wrapper with PANTS_SHA support (pantsbuild#42)

Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.

* Upgrade to 2.0.0b1 (pantsbuild#44)

* Upgrade to 2.0.0b3 (pantsbuild#45)

* Upgrade to 2.0.0rc0 (pantsbuild#46)

* Enable MyPy (pantsbuild#47)

This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints.

* Upgrade to 2.0.0rc1 (pantsbuild#48)

This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path.

* Upgrade to 2.0.0rc2 (pantsbuild#49)

* Bump to 2.0.0rc3. (pantsbuild#50)

* Upgrade to 2.0.0 (pantsbuild#51)

* Upgrade to 2.1.0rc0 (pantsbuild#52)

* Update to the latest `./pants` script (pantsbuild#53)

This prepares us for 2.2 removing support for running with Py36.

* add missing BUILD file.

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
Co-authored-by: Tom Dyas <tdyas@toolchain.com>
Co-authored-by: Stu Hood <stuhood@gmail.com>
asherf added a commit to toolchainlabs/example-python that referenced this pull request Nov 18, 2020
@asherf @danieljanes
@benjyw @Eric-Arellano @tdyas @stuhood
Merge Upstream (#21)
96040d7 
* Update `pants` and `pants.toml` for 2.0 release (#26)

* Fix the setup-py part of the example. (#30)

Required moving the .proto files to be
below the exported target (in the filesystem
sense).

If we support setting a source root on
generated protos in the future, we can
modify this further to demo that.

* Upgrade to 2.0.0.dev7 (pantsbuild#33)

Remaining followups:

* [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI.
* [ ] Turn on dependency inference. Needs docs update.
* [ ] Enable MyPy.
* [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update.
* [ ] Use `resolve_all_constraints`. Needs docs update.
* [ ] Fix all references to readme.io. Fix the `master` branch too.
* [ ] Update the `./pants` script. Fix the `master` branch too.

* Update doc URLs to pantsbuild.org (pantsbuild#35)

* Upgrade to 2.0.0.dev8 (pantsbuild#37)

* Add py2 __init__.py files. (pantsbuild#39)

Otherwise `./pants run helloworld:helloworld_py2` doesn't work.

* Upgrade to Pants 2.0.0.dev9 (pantsbuild#38)

* Upgrade to 2.0.0b0 (pantsbuild#40)

* Turn on dependency inference (pantsbuild#41)

* update ./pants wrapper with PANTS_SHA support (pantsbuild#42)

Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.

* Upgrade to 2.0.0b1 (pantsbuild#44)

* Upgrade to 2.0.0b3 (pantsbuild#45)

* Upgrade to 2.0.0rc0 (pantsbuild#46)

* Enable MyPy (pantsbuild#47)

This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints.

* Upgrade to 2.0.0rc1 (pantsbuild#48)

This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path.

* Upgrade to 2.0.0rc2 (pantsbuild#49)

* Bump to 2.0.0rc3. (pantsbuild#50)

* Upgrade to 2.0.0 (pantsbuild#51)

* Upgrade to 2.1.0rc0 (pantsbuild#52)

* Update to the latest `./pants` script (pantsbuild#53)

This prepares us for 2.2 removing support for running with Py36.

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
Co-authored-by: Tom Dyas <tdyas@toolchain.com>
Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdyas @Eric-Arellano @asherf @benjyw