Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ./pants wrapper with PANTS_SHA support #42

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Sep 17, 2020

Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is all copied, right? From which repo. It's becoming harder to keep track of what is and what is not updated.

@tdyas
Copy link
Contributor Author

tdyas commented Sep 17, 2020

From the official location: https://pantsbuild.github.io/setup/pants

I don't know what repo backs that though.

@tdyas tdyas merged commit 817f587 into pantsbuild:main Sep 17, 2020
@tdyas tdyas deleted the pants_sha_support_in_wrapper branch September 17, 2020 03:08
asherf added a commit to toolchainlabs/example-python that referenced this pull request Nov 13, 2020
* Update `pants` and `pants.toml` for 2.0 release (#26)

* Fix the setup-py part of the example. (#30)

Required moving the .proto files to be
below the exported target (in the filesystem
sense).

If we support setting a source root on
generated protos in the future, we can
modify this further to demo that.

* Upgrade to 2.0.0.dev7 (pantsbuild#33)

Remaining followups:

* [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI.
* [ ] Turn on dependency inference. Needs docs update.
* [ ] Enable MyPy.
* [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update.
* [ ] Use `resolve_all_constraints`. Needs docs update.
* [ ] Fix all references to readme.io. Fix the `master` branch too.
* [ ] Update the `./pants` script. Fix the `master` branch too.

* Update doc URLs to pantsbuild.org (pantsbuild#35)

* Upgrade to 2.0.0.dev8 (pantsbuild#37)

* Add py2 __init__.py files. (pantsbuild#39)

Otherwise `./pants run helloworld:helloworld_py2` doesn't work.

* Upgrade to Pants 2.0.0.dev9 (pantsbuild#38)

* Upgrade to 2.0.0b0 (pantsbuild#40)

* Turn on dependency inference (pantsbuild#41)

* update ./pants wrapper with PANTS_SHA support (pantsbuild#42)

Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.

* Upgrade to 2.0.0b1 (pantsbuild#44)

* Upgrade to 2.0.0b3 (pantsbuild#45)

* Upgrade to 2.0.0rc0 (pantsbuild#46)

* Enable MyPy (pantsbuild#47)

This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints.

* Upgrade to 2.0.0rc1 (pantsbuild#48)

This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path.

* Upgrade to 2.0.0rc2 (pantsbuild#49)

* Bump to 2.0.0rc3. (pantsbuild#50)

* Upgrade to 2.0.0 (pantsbuild#51)

* Upgrade to 2.1.0rc0 (pantsbuild#52)

* Update to the latest `./pants` script (pantsbuild#53)

This prepares us for 2.2 removing support for running with Py36.

* add missing BUILD file.

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
Co-authored-by: Tom Dyas <tdyas@toolchain.com>
Co-authored-by: Stu Hood <stuhood@gmail.com>
asherf added a commit to toolchainlabs/example-python that referenced this pull request Nov 18, 2020
* Update `pants` and `pants.toml` for 2.0 release (#26)

* Fix the setup-py part of the example. (#30)

Required moving the .proto files to be
below the exported target (in the filesystem
sense).

If we support setting a source root on
generated protos in the future, we can
modify this further to demo that.

* Upgrade to 2.0.0.dev7 (pantsbuild#33)

Remaining followups:

* [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI.
* [ ] Turn on dependency inference. Needs docs update.
* [ ] Enable MyPy.
* [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update.
* [ ] Use `resolve_all_constraints`. Needs docs update.
* [ ] Fix all references to readme.io. Fix the `master` branch too.
* [ ] Update the `./pants` script. Fix the `master` branch too.

* Update doc URLs to pantsbuild.org (pantsbuild#35)

* Upgrade to 2.0.0.dev8 (pantsbuild#37)

* Add py2 __init__.py files. (pantsbuild#39)

Otherwise `./pants run helloworld:helloworld_py2` doesn't work.

* Upgrade to Pants 2.0.0.dev9 (pantsbuild#38)

* Upgrade to 2.0.0b0 (pantsbuild#40)

* Turn on dependency inference (pantsbuild#41)

* update ./pants wrapper with PANTS_SHA support (pantsbuild#42)

Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.

* Upgrade to 2.0.0b1 (pantsbuild#44)

* Upgrade to 2.0.0b3 (pantsbuild#45)

* Upgrade to 2.0.0rc0 (pantsbuild#46)

* Enable MyPy (pantsbuild#47)

This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints.

* Upgrade to 2.0.0rc1 (pantsbuild#48)

This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path.

* Upgrade to 2.0.0rc2 (pantsbuild#49)

* Bump to 2.0.0rc3. (pantsbuild#50)

* Upgrade to 2.0.0 (pantsbuild#51)

* Upgrade to 2.1.0rc0 (pantsbuild#52)

* Update to the latest `./pants` script (pantsbuild#53)

This prepares us for 2.2 removing support for running with Py36.

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
Co-authored-by: Tom Dyas <tdyas@toolchain.com>
Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants