Skip to content

Commit

Permalink
Temporarily fix a test that relies on the state of the world. (#12153)
Browse files Browse the repository at this point in the history
certifi published a new version, and this broke some tests of
pex resolution that assumed an earlier version would be resolved.

This is a short-term fix to get tests running, but this test
needs to be fixed to not depend on external state.

[ci skip-rust]

[ci skip-build-wheels]
  • Loading branch information
benjyw authored May 30, 2021
1 parent 7398892 commit 2d62aa9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/python/pants/backend/python/util_rules/pex_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def assert_direct_requirements(pex_info):
)
assert_direct_requirements(direct_pex_info)
assert {
"certifi-2020.12.5-py2.py3-none-any.whl",
"certifi-2021.5.30-py2.py3-none-any.whl",
"chardet-3.0.4-py2.py3-none-any.whl",
"idna-2.10-py2.py3-none-any.whl",
"requests-2.23.0-py2.py3-none-any.whl",
Expand Down Expand Up @@ -378,7 +378,7 @@ def test_venv_pex_resolve_info(rule_runner: RuleRunner, pex_type: type[Pex | Ven
rule_runner, pex_type=pex_type, requirements=PexRequirements(["requests==2.23.0"])
)["pex"]
dists = rule_runner.request(PexResolveInfo, [venv_pex])
assert dists[0] == PexDistributionInfo("certifi", Version("2020.12.5"), None, ())
assert dists[0] == PexDistributionInfo("certifi", Version("2021.05.30"), None, ())
assert dists[1] == PexDistributionInfo("chardet", Version("3.0.4"), None, ())
assert dists[2] == PexDistributionInfo(
"idna", Version("2.10"), SpecifierSet("!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,>=2.7"), ()
Expand Down

0 comments on commit 2d62aa9

Please sign in to comment.