Temporarily fix a test that relies on the state of the world. #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. [ci skip-rust] [ci skip-build-wheels]
|
I don't totally understand what this test is testing and therefore what the appropriate fix would be (e.g., would adding constraints be appropriate, or would that defeat the purpose of the test in some way?) So I will leave that to others. |
jsirois
approved these changes
May 30, 2021
|
Issue: #12154 |
jsirois
pushed a commit
to jsirois/pants
that referenced
this pull request
Jun 1, 2021
…uild#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. [ci skip-rust] [ci skip-build-wheels]
jsirois
pushed a commit
to jsirois/pants
that referenced
this pull request
Jun 1, 2021
…uild#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. [ci skip-rust] [ci skip-build-wheels] (cherry picked from commit 2d62aa9)
jsirois
pushed a commit
to jsirois/pants
that referenced
this pull request
Jun 1, 2021
…uild#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. [ci skip-rust] [ci skip-build-wheels] (cherry picked from commit 2d62aa9)
jsirois
added a commit
that referenced
this pull request
Jun 1, 2021
#12162) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
jsirois
added a commit
that referenced
this pull request
Jun 1, 2021
#12163) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. (cherry picked from commit 2d62aa9) Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
jsirois
pushed a commit
to jsirois/pants
that referenced
this pull request
Jun 1, 2021
…uild#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. [ci skip-rust] [ci skip-build-wheels] (cherry picked from commit 2d62aa9)
jsirois
added a commit
that referenced
this pull request
Jun 1, 2021
+ Temporarily fix a test that relies on the state of the world. (#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. (cherry picked from commit 2d62aa9) + Fix black tests in CI. (#12062) (cherry picked from commit e0927e9) Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
jsirois
added a commit
that referenced
this pull request
Jun 2, 2021
+ Temporarily fix a test that relies on the state of the world. (#12153) certifi published a new version, and this broke some tests of pex resolution that assumed an earlier version would be resolved. This is a short-term fix to get tests running, but this test needs to be fixed to not depend on external state. (cherry picked from commit 2d62aa9) + Fix black tests in CI. (#12062) (cherry picked from commit e0927e9) Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
certifi published a new version, and this broke some tests of
pex resolution that assumed an earlier version would be resolved.
This is a short-term fix to get tests running, but this test
needs to be fixed to not depend on external state.
[ci skip-rust]
[ci skip-build-wheels]