Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix a test that relies on the state of the world. (#12153) #12162

Merged

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jun 1, 2021

certifi published a new version, and this broke some tests of
pex resolution that assumed an earlier version would be resolved.

This is a short-term fix to get tests running, but this test
needs to be fixed to not depend on external state.

[ci skip-rust]

[ci skip-build-wheels]

(cherry picked from commit 2d62aa9)

…uild#12153)

certifi published a new version, and this broke some tests of
pex resolution that assumed an earlier version would be resolved.

This is a short-term fix to get tests running, but this test
needs to be fixed to not depend on external state.

[ci skip-rust]

[ci skip-build-wheels]
@jsirois
Copy link
Contributor Author

jsirois commented Jun 1, 2021

This is to stabilize CI for 2.5.x.

@jsirois jsirois requested review from Eric-Arellano and benjyw June 1, 2021 19:52
@jsirois jsirois merged commit 38b2dd8 into pantsbuild:2.5.x Jun 1, 2021
@jsirois jsirois deleted the pr/12153/fix-CI/cherry-pick/2.5.x branch June 1, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants