Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailor should not create targets for unparseable requirements.txt/pyproject.toml/etc. #15734

Closed
stuhood opened this issue Jun 2, 2022 · 1 comment · Fixed by #15755
Closed
Assignees
Labels
backend: Python Python backend-related issues onboarding Issues that affect a new user's onboarding experience

Comments

@stuhood
Copy link
Member

stuhood commented Jun 2, 2022

As described in #15276, tailor will currently generate targets which cover invalid requirements.txt files (and although not covered there, also pyproject.toml, etc). While improving our support for parsing those file types is definitely beneficial, our utmost priority should be that tailor leaves a repository in a state where a command like peek will not fail.

To that end, the Python tailor implementation should begin doing some lightweight validation of the files consumed by these macros before creating targets for them, and warning for any files that it will skip (with a message indicating how to silence the warning).

@chrisjrn
Copy link
Contributor

chrisjrn commented Jun 3, 2022

Validation for requirements.txt files now work; will add pipenv and poetry next.

chrisjrn pushed a commit that referenced this issue Jun 7, 2022
Adds basic validation for `requirements.txt`, pipfile, and `pyproject.toml` by tailor so that we don't permanently start trying to ingest invalid files.

Closes #15734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Python Python backend-related issues onboarding Issues that affect a new user's onboarding experience
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants