tailor should skip bad requirements targets
#15755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 3, 2022 14:03
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
added 5 commits
June 6, 2022 12:32
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
chrisjrn
changed the title
tailor should skip bad requirements targetstailor should skip bad requirements targets
| f"No target generated for `{fp}`. You'll need to create " | ||
| "targets for its contents manually." | ||
| ) | ||
| logger.warning("") |
There was a problem hiding this comment.
Is this to have a newline? We have no precedent for this, and imo it's confusing to see WARN twice.
If you really wanted a newline, it's better to use \n in the call above. But again, no precedent for that.
There was a problem hiding this comment.
Also, probably better to combine the warning with the implementation-specific warnings. We try to have logs be self-contained
stuhood
approved these changes
Jun 6, 2022
|
I'll add in @stuhood's suggestions, and come back to @Eric-Arellano's as a follow-up |
Other than |
added 2 commits
June 6, 2022 14:57
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Yup, it's the |
stuhood
approved these changes
Jun 6, 2022
| f"An error occurred when validating `{fp}`: {e}.\n\n" | ||
| "You'll need to create targets for its contents manually.\n" | ||
| "To silence this error in future, see " | ||
| "https://www.pantsbuild.org/docs/reference-tailor#section-ignore-paths \n" |
There was a problem hiding this comment.
Should use from pants.util.docutil import doc_url for this.
| logger.warning( | ||
| f"An error occurred when validating `{fp}`: {e}.\n\n" | ||
| "You'll need to create targets for its contents manually.\n" | ||
| "To silence this error in future, see " |
There was a problem hiding this comment.
Suggested change
| "To silence this error in future, see " | |
| "To silence this warning in future, see " |
Comment on lines
+181
to
+182
| for _ in parse_requirements_file(contents.decode(), rel_path=path): | ||
| pass |
There was a problem hiding this comment.
Suggested change
| for _ in parse_requirements_file(contents.decode(), rel_path=path): | |
| pass | |
| parse_requirements_file(contents.decode(), rel_path=path): |
There was a problem hiding this comment.
It's a generator, we need to consume its output somehow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic validation for
requirements.txt, pipfile, andpyproject.tomlby tailor so that we don't permanently start trying to ingest invalid files.Closes #15734