Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native InteractiveProcess {chroot} support to avoid re-downloading JDKs for run #16104

Closed
stuhood opened this issue Jul 8, 2022 · 1 comment · Fixed by #16273
Closed

Use native InteractiveProcess {chroot} support to avoid re-downloading JDKs for run #16104

stuhood opened this issue Jul 8, 2022 · 1 comment · Fixed by #16273
Assignees
@chrisjrn
Labels
backend: JVM JVM backend-related issues

Comments

@stuhood
Copy link
Member

stuhood commented Jul 8, 2022

#16093 adds support for immutable_inputs and append_only_caches to InteractiveProcess. That support should be used to avoid downloading a separate JDK for the deploy_jar run implementation.
@stuhood stuhood added the backend: JVM JVM backend-related issues label Jul 8, 2022
@chrisjrn chrisjrn self-assigned this Jul 22, 2022
@chrisjrn
Copy link
Contributor

chrisjrn commented Jul 22, 2022 •
edited
Loading

Great news! It'll be a joy to remove the RuntimeJvm hack!

@chrisjrn chrisjrn mentioned this issue Jul 22, 2022
Merged
chrisjrn pushed a commit that referenced this issue Jul 22, 2022
[Internal] run_deploy_jar no longer needs to re-download the JDK (#…
3a9083b 
…16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in #16093. This required adding passthrough args to `RunRequest`.

Closes #16104 and removes a Terrible Terrible Hack.
jyggen pushed a commit to jyggen/pants that referenced this issue Jul 27, 2022
@jyggen
[Internal] run_deploy_jar no longer needs to re-download the JDK (p…
5b81d79 
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood mentioned this issue Aug 2, 2022
Merged
stuhood pushed a commit to stuhood/pants that referenced this issue Aug 2, 2022
@stuhood
[Internal] run_deploy_jar no longer needs to re-download the JDK (p…
ae0c5f9 
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this issue Aug 2, 2022
@stuhood
[Internal] run_deploy_jar no longer needs to re-download the JDK (p…
412fa24 
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood added a commit that referenced this issue Aug 2, 2022
@stuhood
[Internal] run_deploy_jar no longer needs to re-download the JDK (C…
09be8a0 
…herry-pick of #16273) (#16370)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in #16093. This required adding passthrough args to `RunRequest`.

Closes #16104 and removes a Terrible Terrible Hack.

[ci skip-rust]
[ci skip-build-wheels]

Co-authored-by: Christopher Neugebauer <chrisjrn@toolchain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjrn chrisjrn

Labels
backend: JVM JVM backend-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Internal] run_deploy_jar no longer needs to re-download the JDK chrisjrn/pants
2 participants
@stuhood @chrisjrn