[Internal] run_deploy_jar no longer needs to re-download the JDK
#16273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`immutable_inputs` and `append_only_caches` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
chrisjrn
added
the
category:internal
|
I always love a substantial PR that has more red than green in the diff. |
stuhood
approved these changes
Jul 22, 2022
|
@stuhood Tested locally (seems to work), and |
Merged
jyggen
pushed a commit
to jyggen/pants
that referenced
this pull request
Jul 27, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Aug 2, 2022
…herry-pick of #16273) (#16370) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in #16093. This required adding passthrough args to `RunRequest`. Closes #16104 and removes a Terrible Terrible Hack. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Christopher Neugebauer <chrisjrn@toolchain.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the hacky
__RuntimeJvmconstruct withInteractiveProcess' support forimmutable_inputsandappend_only_cachesthat was added in #16093. This required adding passthrough args toRunRequest.Closes #16104 and removes a Terrible Terrible Hack.