Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] run_deploy_jar no longer needs to re-download the JDK #16273

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

chrisjrn
Copy link
Contributor

This replaces the hacky __RuntimeJvm construct with InteractiveProcess' support for immutable_inputs and append_only_caches that was added in #16093. This required adding passthrough args to RunRequest.

Closes #16104 and removes a Terrible Terrible Hack.

…`immutable_inputs` and `append_only_caches`

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@chrisjrn chrisjrn added the category:internal CI, fixes for not-yet-released features, etc. label Jul 22, 2022
@chrisjrn chrisjrn requested a review from stuhood July 22, 2022 16:23
@chrisjrn
Copy link
Contributor Author

I always love a substantial PR that has more red than green in the diff.

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Tested locally I assume?

@chrisjrn
Copy link
Contributor Author

@stuhood Tested locally (seems to work), and run_deploy_jar_integration_test has no regressions.

@chrisjrn chrisjrn merged commit 3a9083b into pantsbuild:main Jul 22, 2022
@chrisjrn chrisjrn deleted the chrisjrn/16104-yeet-runtime-jvm branch July 22, 2022 17:02
@stuhood stuhood added this to the 2.13.x milestone Jul 22, 2022
@stuhood stuhood mentioned this pull request Jul 22, 2022
jyggen pushed a commit to jyggen/pants that referenced this pull request Jul 27, 2022
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this pull request Aug 2, 2022
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this pull request Aug 2, 2022
…antsbuild#16273)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`.

Closes pantsbuild#16104 and removes a Terrible Terrible Hack.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request Aug 2, 2022
…herry-pick of #16273) (#16370)

This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in #16093. This required adding passthrough args to `RunRequest`.

Closes #16104 and removes a Terrible Terrible Hack.

[ci skip-rust]
[ci skip-build-wheels]

Co-authored-by: Christopher Neugebauer <chrisjrn@toolchain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use native InteractiveProcess {chroot} support to avoid re-downloading JDKs for run
2 participants