Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plumb --pants-ignore to watchman startup. #3479

Closed
kwlzn opened this issue May 20, 2016 · 2 comments · Fixed by #9714
Closed

plumb --pants-ignore to watchman startup. #3479

kwlzn opened this issue May 20, 2016 · 2 comments · Fixed by #9714
Assignees
@kwlzn
Milestone
Daemon Backlog

Comments

@kwlzn
Copy link
Member

kwlzn commented May 20, 2016

currently this is hardcoded with two outstanding TODOs:

service/fs_event_service.py
82:          # TODO(kwlzn): Make exclusions here optionable.

subsystem/pants_daemon_launcher.py
99:    # TODO(kwlzn): Thread filesystem path ignores here to Watchman's subscription registration.
@kwlzn kwlzn added the engine label May 20, 2016
@kwlzn kwlzn self-assigned this May 20, 2016
@kwlzn
Copy link
Member Author

kwlzn commented May 25, 2016

I have a functional workup on this, but I'm going to change the approach to use pathspec - after knocking out some other more important tasks.

@kwlzn kwlzn added pantsd and removed engine labels May 25, 2016
@stuhood stuhood mentioned this issue Oct 9, 2017
Merged
@stuhood
Copy link
Member

stuhood commented Jan 10, 2018

Relates to #4999

@kwlzn kwlzn added this to the Daemon Post-Beta milestone Mar 1, 2018
@stuhood stuhood mentioned this issue May 7, 2020
Merged
stuhood pushed a commit that referenced this issue May 7, 2020
Disable watchman by default. (#9714)
5fd31ec 
### Problem

Using the notify crate for file invalidation is now feature complete, and so we are using two file watching implementations simultaneously under `pantsd`.

### Solution

Disable watchman by default, and deprecate it. Additionally, remove the implementation of the `experimental` flag from notify. Fixes #8710, fixes #8198, fixes #7375, fixes #5487, fixes #4999, fixes #3479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwlzn kwlzn

Labels
None yet
Projects
None yet
Milestone
Daemon Backlog
Development

Successfully merging a pull request may close this issue.

Disable watchman by default. stuhood/pants
2 participants
@stuhood @kwlzn